Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: [PATCH] Bluetooth: Fix - During le_conn_timeout disable EXT_ADV
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200218123747.3006-1-sathish.narasimman@intel.com>
Date:   Tue, 18 Feb 2020 15:10:22 +0100
Cc:     linux-bluetooth@vger.kernel.org,
        Sathish Narsimman <sathish.narasimman@intel.com>
Content-Transfer-Encoding: 7bit
Message-Id: <072E9094-BA5F-47CB-9740-B04A6DC5384D@holtmann.org>
References: <20200218123747.3006-1-sathish.narasimman@intel.com>
To:     Sathish Narsimman <nsathish41@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Sathish,

> Disabling LE_LEGACY_ADV when LE_EXT_ADV is enabled causes 'command
> disallowed . This patch fixes that issue and disables EXT_ADV if
> enabled.
> 
> Signed-off-by: Sathish Narsimman <sathish.narasimman@intel.com>
> ---
> net/bluetooth/hci_conn.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index a582c676e584..a8d8a876363c 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -481,9 +481,19 @@ static void le_conn_timeout(struct work_struct *work)
> 	 * (which doesn't have a timeout of its own).
> 	 */
> 	if (conn->role == HCI_ROLE_SLAVE) {
> -		u8 enable = 0x00;
> -		hci_send_cmd(hdev, HCI_OP_LE_SET_ADV_ENABLE, sizeof(enable),
> -			     &enable);
> +		if (ext_adv_capable(hdev)) {
> +			struct hci_cp_le_set_ext_adv_enable cp;
> +
> +			cp.enable = 0x00;
> +			cp.num_of_sets = 0x00;
> +
> +			hci_send_cmd(hdev, HCI_OP_LE_SET_EXT_ADV_ENABLE,
> +				     sizeof(cp), &cp);
> +		} else {
> +			u8 enable = 0x00;
> +			hci_send_cmd(hdev, HCI_OP_LE_SET_ADV_ENABLE,
> +				     sizeof(enable), &enable);
> +		}

hmmm, I wonder if it is better to create a helper function for this.

Regards

Marcel