Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200224151935.169330-1-alainm@chromium.org>
In-Reply-To: <20200224151935.169330-1-alainm@chromium.org>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Wed, 26 Feb 2020 15:39:54 -0500
Message-ID: <CALWDO_V9DbS6h43b+_4B=p4-X+14tc9KgCPzGXJgeMyvKcEDPg@mail.gmail.com>
Subject: Re: [Bluez-PATCH] Add mgmt interface for Erroneous Data Reporting
To:     Alain Michaud <alainm@chromium.org>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 24, 2020 at 10:19 AM Alain Michaud <alainm@chromium.org> wrote:
>
> This change adds the MGMT definition to support Errorneout Data
> Reporting.  This allows higher level application to query and set the
> Erroneous data reporting feature of the controller.  In particular, this
> can be used by an audio subsystem to support wideband speech.
>
After further consideration, it is believed that this MGMT may not be
necessary and instead rely on the driver's indication of Wideband
speech capability to unconditionally enable erroneous data reporting.
This patch can be abandoned.
> ---
>
>  doc/mgmt-api.txt | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 1e59acc54..953c2793d 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -307,6 +307,7 @@ Read Controller Information Command
>                 13      Privacy
>                 14      Controller Configuration
>                 15      Static Address
> +               16      Erroneous Data Reporting
>
>         This command generates a Command Complete event on success or
>         a Command Status event on failure.
> @@ -3048,6 +3049,26 @@ Load Blocked Keys Command
>                                 Invalid Index
>
>
> +Set Erroneous Data Reporting Command
> +=======================
> +
> +       Command Code:           0x0047
> +       Controller Index:       <controller id>
> +       Command Parameters:     ErroneousDataReporting (1 Octet)
> +       Return Parameters:
> +
> +       This command is used to set the Erroneous Data Reporting property of
> +       a controller. The allowed Connectable command parameter values are
> +       0x00 and 0x01. All other values will return Invalid Parameters.
> +
> +       This command generates a Command Complete event on success or
> +       a Command Status event on failure.
> +
> +       Possible errors:        Busy
> +                               Not Supported
> +                               Invalid Parameters
> +                               Invalid Index
> +
>  Command Complete Event
>  ======================
>
> --
> 2.25.0.265.gbab2e86ba0-goog
>