Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: [PATCH v1] bluetooth: guard against controllers sending zero'd
 events
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <788439D3-E0CC-4CBA-99C2-0B9C3703B23D@holtmann.org>
Date:   Sat, 29 Feb 2020 10:44:27 +0200
Cc:     Alain Michaud <alainm@chromium.org>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C59D3CDE-0EA8-4839-A34E-5ADA1BDE4949@gmail.com>
References: <20200228205146.161229-1-alainm@chromium.org>
 <788439D3-E0CC-4CBA-99C2-0B9C3703B23D@holtmann.org>
To:     Marcel Holtmann <marcel@holtmann.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

On 29. Feb 2020, at 9.14, Marcel Holtmann <marcel@holtmann.org> wrote:
>> --- a/net/bluetooth/hci_event.c
>> +++ b/net/bluetooth/hci_event.c
>> @@ -5868,7 +5868,8 @@ void hci_event_packet(struct hci_dev *hdev, =
struct sk_buff *skb)
>> 	u8 status =3D 0, event =3D hdr->evt, req_evt =3D 0;
>> 	u16 opcode =3D HCI_OP_NOP;
>>=20
>> -	if (hdev->sent_cmd && bt_cb(hdev->sent_cmd)->hci.req_event =3D=3D =
event) {
>> +	if (hdev->sent_cmd && event &&
>> +	    bt_cb(hdev->sent_cmd)->hci.req_event =3D=3D event) {
>=20
> Why are you bothering to check for event here. Do we have requests set =
with hci_req.event =3D=3D 0?

If I remember right, most requests are like that. req.event is only used =
then the request completes in something else than a command =
complete/status.

Johan=