Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: [PATCH v1] bluetooth: guard against controllers sending zero'd
 events
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <14FD24FA-1455-4FE4-832B-9851D9E22780@holtmann.org>
Date:   Sun, 1 Mar 2020 10:38:20 +0200
Cc:     Alain Michaud <alainm@chromium.org>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A417E313-0ABE-46D6-92CD-434DDCC2D573@gmail.com>
References: <20200228205146.161229-1-alainm@chromium.org>
 <788439D3-E0CC-4CBA-99C2-0B9C3703B23D@holtmann.org>
 <C59D3CDE-0EA8-4839-A34E-5ADA1BDE4949@gmail.com>
 <14FD24FA-1455-4FE4-832B-9851D9E22780@holtmann.org>
To:     Marcel Holtmann <marcel@holtmann.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

On 1. Mar 2020, at 4.44, Marcel Holtmann <marcel@holtmann.org> wrote:
>>> Why are you bothering to check for event here. Do we have requests =
set with hci_req.event =3D=3D 0?
>>=20
>> If I remember right, most requests are like that. req.event is only =
used then the request completes in something else than a command =
complete/status.
>=20
> so what do we do then if we get an event =3D=3D 0 from the controller? =
Just bail out early? It seems kind pointless to keep processing it.

Yeah, that=E2=80=99s what I=E2=80=99d do. Bail out early, but log a =
warning.

Johan=