Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4650456ybf; Wed, 4 Mar 2020 08:03:19 -0800 (PST) X-Google-Smtp-Source: ADFU+vtZf0uy0Tw8jylpuXfaf6Y/W2vMLx4qfBkdP2E/+7lLJ9Y9xpYW1v1ntCLvtM5rjPTApPz3 X-Received: by 2002:a05:6830:18f7:: with SMTP id d23mr2929741otf.369.1583337799073; Wed, 04 Mar 2020 08:03:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583337799; cv=none; d=google.com; s=arc-20160816; b=fHwgZXOUF3W3QpQVPB/Wz7Y2N/46fjZZOGTlmNccX5QTOU1JcIPu4x7F9C6TFUOiiw 6ABkNxXdCq9VciTFgOpFwqLIJ8qWctj7cECUlffXUQoDVe1xYUrjL1VZ8uohKLQQ6htE XPWa+z9l5ozLcyC5IQzc6bjb4GMR0djsRIHxzcQYkYGVowoj2tVaD5ZfW0qw/aC3fD/v jHbWt0hAZ6cDebeQ0GNC4TwHE25T0gQdbOlV/ev067y0in/RlEbRZf39gmPPefP32w13 OjEnDdFixt5oZV5/BQo56vh+C6jwBK5aGJfu9YdqpnU/Kuvq0qWhTOe6h2pLYc/insbn ExlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=OUmZkT6taqb64UPAjcNe3zyJ1VocFspAIptz/N3dwH8=; b=Ss9OUKxNbosSPT3sowGzj+u6KUKRYehS9RoVsLll0q90GEzrHUAk3X6MlwF1pkWEPS heKTc92FUSIKGRz9/xb3hPRSRgjfEkbDkaKEsOvMJBHkXZcir3AKkXjqVMsMo2xLiOUQ meSvy2PDCHYslE6kf8pUdpFzsWjfvWnarhxukXgON2LSlMn6VfcIhFAYWwOTynkaJKR4 3Cfndi3TLlti5sSs9L69CJ8pGVG2ZZwpd8i2bwAFvaCdILJcNtL/NNX6mzhYSWGaLc4+ dQwIDlI7XFnemahQ1DTzUp7yuRr/XzV8JrxF88vnnd/H5JSuocaGa5kA4fzf9GW9aJqA j7nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x189si244775oia.270.2020.03.04.08.03.00; Wed, 04 Mar 2020 08:03:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727023AbgCDQCx convert rfc822-to-8bit (ORCPT + 99 others); Wed, 4 Mar 2020 11:02:53 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:55886 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbgCDQCx (ORCPT ); Wed, 4 Mar 2020 11:02:53 -0500 Received: from marcel-macpro.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 73B6ECECDF; Wed, 4 Mar 2020 17:12:19 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: [PATCH v1] Bluetooth: hci_qca: Replace devm_gpiod_get() with devm_gpiod_get_optional() From: Marcel Holtmann In-Reply-To: <20200304131645.22057-1-rjliao@codeaurora.org> Date: Wed, 4 Mar 2020 17:02:51 +0100 Cc: Johan Hedberg , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org, c-hbandi@codeaurora.org, hemantg@codeaurora.org, mka@chromium.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20200304131645.22057-1-rjliao@codeaurora.org> To: Rocky Liao X-Mailer: Apple Mail (2.3608.60.0.2.5) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Rocky, > This patch replaces devm_gpiod_get() with devm_gpiod_get_optional() to get > bt_en and replaces devm_clk_get() with devm_clk_get_optional() to get > susclk. It also uses NULL check to determine whether the resource is > available or not. > > Fixes: 8a208b24d770 ("Bluetooth: hci_qca: Make bt_en and susclk not mandatory for QCA Rome") > Signed-off-by: Rocky Liao > --- > drivers/bluetooth/hci_qca.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel