Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200304173249.66324-1-alainm@chromium.org> <1990C7E4-CB11-48A5-B07D-A06A94FB73EC@holtmann.org>
In-Reply-To: <1990C7E4-CB11-48A5-B07D-A06A94FB73EC@holtmann.org>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Wed, 4 Mar 2020 15:18:11 -0500
Message-ID: <CALWDO_XDw9TPWiW3K8F6_e8u2P4Hv_94-mKq+d82HQaLuqA+dA@mail.gmail.com>
Subject: Re: [BlueZ PATCH v1] Adding definitions for Wide Band Speech configuration
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Alain Michaud <alainm@chromium.org>,
        BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel

Thanks, I will rebase and send a v2 with just the header changes.

Thanks,
Alain

On Wed, Mar 4, 2020 at 1:37 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Alain,
>
> > This change adds the corresponding user space definition for wide band
> > speech.
> >
> > ---
> >
> > doc/mgmt-api.txt | 30 ++++++++++++++++++++++++++++++
> > lib/mgmt.h       |  5 ++++-
> > 2 files changed, 34 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> > index 5c23268a1..ecdfd9b95 100644
> > --- a/doc/mgmt-api.txt
> > +++ b/doc/mgmt-api.txt
> > @@ -3052,6 +3052,36 @@ Load Blocked Keys Command
> >       Possible errors:        Invalid Parameters
> >                               Invalid Index
> >
> > +Set Wide Band Speech Command
> > +======================
> > +
> > +     Command Code:           0x0047
> > +     Controller Index:       <controller id>
> > +     Command Parameters:     wide_band_speech_enabled (1 Octet)
> > +     Return Parameters:      Current_Settings (4 Octets)
> > +
> > +     This command is used to enable/disable Wide Band Speech support for a
> > +     controller. The allowed values of the wide_band_speech_enabled command
> > +     parameter are 0x00 and 0x01. All other values will return
> > +     Invalid Parameters.
> > +
> > +     This command is only available for Wide Band Speech capable controllers and
> > +     will yield in a Not Supported error otherwise.
> > +
> > +     This command can be used when the controller is not powered and
> > +     all settings will be programmed once powered.
> > +
> > +     In case the kernel subsystem does not support Wide Band Speech or the
> > +     controller does not either, the command will fail regardless.
> > +
> > +     This command generates a Command Complete event on success or
> > +     a Command Status event on failure.
> > +
> > +     Possible errors:        Busy
> > +                             Not Supported
> > +                             Invalid Parameters
> > +                             Invalid Index
> > +
>
> I already committed the mgmt-api.txt change since I was fixing a few things in the document.
>
> Regards
>
> Marcel
>