Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp357901ybh; Fri, 6 Mar 2020 23:52:07 -0800 (PST) X-Google-Smtp-Source: ADFU+vtRJE+ri0Foj5VAghJU0H61yg9PNGzaik3pP2t999VTBjwXsphvdwetDOZWzLerztc0AoJP X-Received: by 2002:aca:4e58:: with SMTP id c85mr5383329oib.115.1583567527669; Fri, 06 Mar 2020 23:52:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583567527; cv=none; d=google.com; s=arc-20160816; b=ZgdS9NrWtjhUWdbmwJTj3Tzsa5e042Dx+s0wIo6a9KHIzP7UDb06hYeEiV65ly3vAo Nq1Np76Q/LQQw7zXzGSZu0IoCgcHo9Acpu0D3Vk0muSMxktxaZ04pev9z4H9CMuX/dND bqOF+8CZ2fICGQrHctT99Ubxsw7bYuVopDkmLwO+RNqBG031i74ON4LRhJA3vaIwpuq1 Q8vvfjSsof5odcisWWBgzq40M73cv3NJM21mfxpMO2EUQtwbaz6iWzdaNptJSCedGfZk hdQX9x/C1aBTQ5Ac3ayvp5zcAfr6PFTRBuWGuxxsUcAP2IybH+fIO5wUDIc0/Iep8lJ/ 7vbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=0T2PM8hYmpC+cTcDMNtIQRfi+KfzETyRuSQJNUxBWRw=; b=S832NKp+091z64CufICK7yRGZrthwrMh0TLxomsvtjKzQ1uOIot/di27XLueYl38EF YpNtgkPgunZvlB1kfyOfSb9G5q4eu24h/KGtKAyDrvLyTlsbxLr9gGKFohWCwkJsd6tQ zhl3J+GgF45+2dpSm64Gtm+qnM0gSPM2Jc/GlWtVMOv16CrXQEJlrGAEB2R+uWLWnp2g FJeuuAtKHrEbbt4XrNYWt2TJiWD46XnE0pYhv4dj/T5mKFhqNY2VnhfDxq3NsH47bH4t rPyU71wnB7FaaQXTcTDK7C3iJdUD/KhmKp06It/EB4MM4IGH1CRGlzXLCp2604tyLiFo ivOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZVxbIUwd; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h201si1013360oib.214.2020.03.06.23.51.34; Fri, 06 Mar 2020 23:52:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZVxbIUwd; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbgCGHvU (ORCPT + 99 others); Sat, 7 Mar 2020 02:51:20 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40545 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgCGHvU (ORCPT ); Sat, 7 Mar 2020 02:51:20 -0500 Received: by mail-pg1-f195.google.com with SMTP id t24so2195278pgj.7 for ; Fri, 06 Mar 2020 23:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0T2PM8hYmpC+cTcDMNtIQRfi+KfzETyRuSQJNUxBWRw=; b=ZVxbIUwdJL+jBCTRNypo0vOUuuq4tJZC6P7LP0+H1nTnbTWDfQ87oFR1C3Qo4PM4+2 bHCVeAi5Fs4Qr4vvr6U7hJR0E5ofJ0JHPBEdVLpdJEvRIeRHq0/fIFtOvikylxviX4aa CIs5BsjE4ZuXDsImW1G+OjnAt7IlsBFrCxGlTy1qbh16CcB9q1ziKz0HcaEmHs1rTJ7V xsu8Auz6CCftUE+uJqIKwN3WETCHN3cYphp8HrdGn7iY0jkrROFc/Wt6VqDN+IPYFYBN A6Mk0JqYH3UY8nDbR+yDvwAwDGfCXWKVBhiXoOrfx4O8bPpZ7TLyF/9MuWLmnoDjDrlr ltFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=0T2PM8hYmpC+cTcDMNtIQRfi+KfzETyRuSQJNUxBWRw=; b=YLauO6lajSoOs+uYB4vo9IKBuEuoiQGFU04DzrrdMiii+SRb6g+ySWaVr57LmyabXI VOPReihTCmIaJiNhdGZPZEAJSrSQ+X1dsGIRgpPA40bd8ctKFIcruGjZdWjaWXZwoilS xu7LR8RzURA3XkTa1B6s8T6vyRsJhIX1QS+8vbL8owP910pZc8ERo3EJqT9UkjyYQDTp N8p8YKV4/a9i+Z/5s4YfaTzVRXDOBk7VxpyO4lm4qf5HwKEk2AFyvGQ9l8oFnv1+49ln UFXse5LSaxmMgqgvC/vCL3UiMaawZG8NGpnKn5WCYXPCzD7IdeN0UMVatDb9A7TUxKgV gV2A== X-Gm-Message-State: ANhLgQ1shxQPpZUVnkJBcpYhKcQIAJgugUEcUdUhNz/51VPCaDY00/7Q fKflaPre72FVdJ38LSABPis916rUdemnEQ== X-Received: by 2002:aa7:8089:: with SMTP id v9mr7877046pff.182.1583567479157; Fri, 06 Mar 2020 23:51:19 -0800 (PST) Received: from localhost ([192.55.54.42]) by smtp.gmail.com with ESMTPSA id f20sm11134745pfk.69.2020.03.06.23.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 23:51:18 -0800 (PST) Date: Sat, 7 Mar 2020 09:51:14 +0200 From: Johan Hedberg To: Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix calculation of SCO handle for packet processing Message-ID: <20200307075114.GA20667@kennedyj-mobl1.ger.corp.intel.com> Mail-Followup-To: Marcel Holtmann , linux-bluetooth@vger.kernel.org References: <20200305152839.92437-1-marcel@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305152839.92437-1-marcel@holtmann.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Thu, Mar 05, 2020, Marcel Holtmann wrote: > When processing SCO packets, the handle is wrongly assumed as 16-bit > value. The actual size is 12-bits and the other 4-bits are used for > packet flags. > > Signed-off-by: Marcel Holtmann > --- > net/bluetooth/hci_core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied to bluetooth-next. Thanks. Johan