Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200312073045.26416-1-lukasz.rymanowski@codecoup.pl>
In-Reply-To: <20200312073045.26416-1-lukasz.rymanowski@codecoup.pl>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 12 Mar 2020 16:29:46 -0700
Message-ID: <CABBYNZLdsqBGUUxyv_TSggqEKvzYT-gFEK_abAii4q3BfdadHg@mail.gmail.com>
Subject: Re: [PATCH BlueZ] monitor: Fix for incorrect len in L2CAP Enhanced Reconfigure
To:     =?UTF-8?Q?=C5=81ukasz_Rymanowski?= <lukasz.rymanowski@codecoup.pl>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi =C5=81ukasz,

On Thu, Mar 12, 2020 at 12:32 AM =C5=81ukasz Rymanowski
<lukasz.rymanowski@codecoup.pl> wrote:
>
> ---
>  monitor/l2cap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/l2cap.c b/monitor/l2cap.c
> index 9409604c3..41c766863 100644
> --- a/monitor/l2cap.c
> +++ b/monitor/l2cap.c
> @@ -1408,7 +1408,7 @@ static void sig_ecred_conn_rsp(const struct l2cap_f=
rame *frame)
>         const struct bt_l2cap_pdu_ecred_conn_rsp *pdu =3D frame->data;
>         uint16_t dcid;
>
> -       l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
> +       l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
>
>         print_field("MTU: %u", le16_to_cpu(pdu->mtu));
>         print_field("MPS: %u", le16_to_cpu(pdu->mps));
> @@ -1426,7 +1426,7 @@ static void sig_ecred_reconf_req(const struct l2cap=
_frame *frame)
>         const struct bt_l2cap_pdu_ecred_reconf_req *pdu =3D frame->data;
>         uint16_t scid;
>
> -       l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
> +       l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
>
>         print_field("MTU: %u", le16_to_cpu(pdu->mtu));
>         print_field("MPS: %u", le16_to_cpu(pdu->mps));
> --
> 2.20.1

Applied, thanks.

--=20
Luiz Augusto von Dentz