Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200312100754.3445-1-sathish.narasimman@intel.com>
 <20200312100754.3445-2-sathish.narasimman@intel.com> <AD87C0E6-8A18-4016-9A4C-CE2934B6F862@holtmann.org>
In-Reply-To: <AD87C0E6-8A18-4016-9A4C-CE2934B6F862@holtmann.org>
From:   Sathish Narasimman <nsathish41@gmail.com>
Date:   Wed, 18 Mar 2020 16:17:17 +0530
Message-ID: <CAOVXEJL7wqq4CBszn697sD1_fi7Em7QANGHkxa1QE5ZE2S4cnQ@mail.gmail.com>
Subject: Re: [PATCH 1/7] Bluetooth: LL Privacy Delete Store Resolving list
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Sathish Narsimman <sathish.narasimman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel

On Wed, Mar 18, 2020 at 4:12 PM Marcel Holtmann <marcel@holtmann.org> wrote=
:
>
> Hi Sathish,
>
> > This patch help to delte the resolving list stored in the BT
> > Controller w.r.t BD_ADDR.
> >
> > Signed-off-by: Sathish Narsimman <sathish.narasimman@intel.com>
> > ---
> > include/net/bluetooth/hci.h      |  1 +
> > include/net/bluetooth/hci_core.h |  2 ++
> > net/bluetooth/hci_request.c      | 33 ++++++++++++++++++++++++++++++++
> > 3 files changed, 36 insertions(+)
> >
> > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> > index 5f60e135aeb6..352bc43940ff 100644
> > --- a/include/net/bluetooth/hci.h
> > +++ b/include/net/bluetooth/hci.h
> > @@ -457,6 +457,7 @@ enum {
> > #define HCI_LE_DATA_LEN_EXT           0x20
> > #define HCI_LE_PHY_2M                 0x01
> > #define HCI_LE_PHY_CODED              0x08
> > +#define HCI_LE_LL_PRIVACY            0x40
> > #define HCI_LE_EXT_ADV                        0x10
> > #define HCI_LE_EXT_SCAN_POLICY                0x80
> > #define HCI_LE_PHY_2M                 0x01
> > diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/h=
ci_core.h
> > index d4e28773d378..5f04ef88da35 100644
> > --- a/include/net/bluetooth/hci_core.h
> > +++ b/include/net/bluetooth/hci_core.h
> > @@ -1657,6 +1657,8 @@ void hci_le_start_enc(struct hci_conn *conn, __le=
16 ediv, __le64 rand,
> >
> > void hci_copy_identity_address(struct hci_dev *hdev, bdaddr_t *bdaddr,
> >                              u8 *bdaddr_type);
> > +void hci_req_del_from_resolving_list(struct hci_dev *hdev, u8 addr_typ=
e,
> > +                                  bdaddr_t *bdaddr);
> >
> > #define SCO_AIRMODE_MASK       0x0003
> > #define SCO_AIRMODE_CVSD       0x0000
> > diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> > index bf83179ab9d1..f4bbd3b79210 100644
> > --- a/net/bluetooth/hci_request.c
> > +++ b/net/bluetooth/hci_request.c
> > @@ -885,6 +885,39 @@ static void hci_req_start_scan(struct hci_request =
*req, u8 type, u16 interval,
> >       }
> > }
> >
> > +void hci_req_del_from_resolving_list(struct hci_dev *hdev, u8 addr_typ=
e, bdaddr_t *bdaddr)
> > +{
> > +     struct hci_cp_le_del_from_resolv_list cp;
> > +     struct hci_request req;
> > +     struct bdaddr_list_with_irk *irk;
> > +
> > +     BT_DBG("");
> > +
> > +     /* Nothing to be done if LL privacy is not supported */
> > +     if ( !(hdev->le_features[0] & HCI_LE_LL_PRIVACY) )
> > +             return;
> > +
> > +     if ( !hci_dev_test_flag(hdev, HCI_LL_RPA_RESOLUTION) &&
> > +         ( hci_dev_test_flag(hdev, HCI_LE_ADV) ||
> > +           hci_dev_test_flag(hdev, HCI_LE_SCAN) ||
> > +           hci_lookup_le_connect(hdev) ) )
> > +             return;
>
> please don=E2=80=99t invent your own coding style. Follow the netdev conv=
ention.

Sure will correct the coding style in next version of the patch
>
> Regards
>
> Marcel
>