Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200316224023.1.I002569822232363cfbb5af1f33a293ea390c24c7@changeid>
 <4DF7C709-1AD3-42FF-A0C2-EF488D82F083@holtmann.org>
In-Reply-To: <4DF7C709-1AD3-42FF-A0C2-EF488D82F083@holtmann.org>
From:   Emil Lenngren <emil.lenngren@gmail.com>
Date:   Wed, 18 Mar 2020 12:31:35 +0100
Message-ID: <CAO1O6sdfdVavo9U0UKewbS9YAjCVzdXDYms-OJZNEJVzMmkgMg@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: Do not cancel advertising when starting a scan
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Manish Mandlik <mmandlik@google.com>,
        Yoni Shavit <yshavit@chromium.org>,
        Alain Michaud <alainm@chromium.org>,
        Miao-chen Chou <mcchou@chromium.org>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Dmitry Grinberg <dmitrygr@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

Den ons 18 mars 2020 kl 12:27 skrev Marcel Holtmann <marcel@holtmann.org>:
>
> Hi Manish,
>
> > BlueZ cancels adv when starting a scan, but does not cancel a scan when
> > starting to adv. Neither is required, so this brings both to a
> > consistent state (of not affecting each other). Some very rare (I've
> > never seen one) BT 4.0 chips will fail to do both at once. Even this is
> > ok since the command that will fail will be the second one, and thus th=
e
> > common sense logic of first-come-first-served is preserved for BLE
> > requests.
> >
> > Signed-off-by: Dmitry Grinberg <dmitrygr@google.com>
> > Signed-off-by: Manish Mandlik <mmandlik@google.com>
> > ---
> >
> > net/bluetooth/hci_request.c | 17 -----------------
> > 1 file changed, 17 deletions(-)
>
> patch has been applied to bluetooth-next tree.
>
> If you know the controller that doesn=E2=80=99t support this, can we blac=
klist that one and just disable advertising (peripheral mode) for that cont=
roller.

Can't the "LE Supported States" be inspected instead to figure out
what simultaneous capabilities are supported? It seems a bit rough to
always assume the worst.

/Emil