Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAOxioNmHcCTkc1MA6Zw8WTPBHCTpE9XZyzfOeuj97EP2NeBw=A@mail.gmail.com>
 <CAOxioN=7jGXxp+=c674Ai3bU5N3f-qRpd3zHDuOdSO93W3dnwQ@mail.gmail.com> <CABBYNZLTj2OjtbVfasAFEzQCGmEpcHzvsbozP2WzPP_UQN29pA@mail.gmail.com>
In-Reply-To: <CABBYNZLTj2OjtbVfasAFEzQCGmEpcHzvsbozP2WzPP_UQN29pA@mail.gmail.com>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Thu, 26 Mar 2020 14:12:34 -0700
Message-ID: <CAOxioN=UrXsrnMZLutmJTMg_OuK1yk-fKTDUU32anJcvHav3gw@mail.gmail.com>
Subject: Re: [PATCH] autopair: Fix compiler warning
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Thanks, Luiz.

On Thu, Mar 26, 2020 at 2:09 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Sonny,
>
> On Thu, Mar 26, 2020 at 10:23 AM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
> >
> > Hi BlueZ maintainers,
> >
> > Could you take a look at this fix? Thank you!
> >
> > On Tue, Mar 24, 2020 at 12:49 PM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
> > >
> > > With clang, comparing an array with NULL generates a warning because the
> > > value is always non-NULL. With maintainer mode enabled, this becomes a
> > > compilation error.
> > > ---
> > >  plugins/autopair.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/plugins/autopair.c b/plugins/autopair.c
> > > index 043bd9b9d..3089430a8 100644
> > > --- a/plugins/autopair.c
> > > +++ b/plugins/autopair.c
> > > @@ -75,7 +75,7 @@ static ssize_t autopair_pincb(struct btd_adapter *adapter,
> > >          btd_device_get_product (device));
> > >
> > >      /* The iCade shouldn't use random PINs like normal keyboards */
> > > -    if (name != NULL && strstr(name, "iCade") != NULL)
> > > +    if (strstr(name, "iCade") != NULL)
> > >          return 0;
> > >
> > >      /* This is a class-based pincode guesser. Ignore devices with an
> > > --
> > > 2.17.1
>
> Applied, thanks.
>
> --
> Luiz Augusto von Dentz