Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200320131356.Bluez.v1.1.Ia3d21e293d18f903fa6e54918856e1dd5ffc904f@changeid>
In-Reply-To: <20200320131356.Bluez.v1.1.Ia3d21e293d18f903fa6e54918856e1dd5ffc904f@changeid>
From:   Archie Pusaka <apusaka@google.com>
Date:   Fri, 27 Mar 2020 10:14:33 +0800
Message-ID: <CAJQfnxENfZnXq4e-kaeKF2ByhJ089JXZumWc9ydBJBWGQgTiGw@mail.gmail.com>
Subject: Re: [Bluez PATCH v1] avdtp: fix delay report valid states
To:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Archie Pusaka <apusaka@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

[re-sending as plain text]
Hi Bluez Maintainers,

Could you take a look at this proposal?

Thank you!


On Fri, 20 Mar 2020 at 13:14, Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> According to AVDTP specification section 6.19,
> avdtp_delayreport_cmd could also be received when the state of SEP
> is open.
>
> Therefore, updating to accommodate such condition.
> ---
>
>  profiles/audio/avdtp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 0e075f9ff..4b0e63384 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session,
>         stream = sep->stream;
>
>         if (sep->state != AVDTP_STATE_CONFIGURED &&
> +                                       sep->state != AVDTP_STATE_OPEN &&
>                                         sep->state != AVDTP_STATE_STREAMING) {
>                 err = AVDTP_BAD_STATE;
>                 goto failed;
> --
> 2.25.1.696.g5e7596f4ac-goog
>