Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 27 Mar 2020 19:55:49 +0100
From:   "michal.lowas-rzechonek@silvair.com" 
        <michal.lowas-rzechonek@silvair.com>
To:     "Gix, Brian" <brian.gix@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "przemyslaw.fierek@silvair.com" <przemyslaw.fierek@silvair.com>,
        "Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ] mesh: Add net key index to send_seg()
Message-ID: <20200327185549.wwuwqwzudw7yeewo@kynes>
Mail-Followup-To: "Gix, Brian" <brian.gix@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "przemyslaw.fierek@silvair.com" <przemyslaw.fierek@silvair.com>,
        "Stotland, Inga" <inga.stotland@intel.com>
References: <20200327131800.7637-1-michal.lowas-rzechonek@silvair.com>
 <4ef38cfb7149f3b52f8ee4e76d718ef25d64fd71.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4ef38cfb7149f3b52f8ee4e76d718ef25d64fd71.camel@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Brian,

On 03/27, Gix, Brian wrote:
> There is one use case which is being missed here: Resends of segments
> of a segmented Device Key message, which do not have a bound net_key,
> and can use *any* net_idx.
> 
> When the initial Outgoing message is composed in mesh_net_app_send(),
> the net_idx is known, and should be fixed for the life of the
> segmented send procedure. I think we should just add net_idx to the
> mesh_sar structure, and use that each time a segment needs to be
> resent.
> 
> And then next, we will probably need to make sure our outgoing ACKs to
> incoming SAR messages are sent on the correct net_key.

Thanks. This sounds good. We'll get back to you with v2 next week.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND