Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2883456ybb; Fri, 27 Mar 2020 13:57:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsWwduafQRuD/8C2z+Y+fGddoBFw1kiZnLVOdldVNGdskPAnxEshsCbh5PGRuN2spIMNt1l X-Received: by 2002:a54:4519:: with SMTP id l25mr627525oil.92.1585342651336; Fri, 27 Mar 2020 13:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585342651; cv=none; d=google.com; s=arc-20160816; b=j/UL2YTG1vGxqnzPVCh608IVciojlhz964srvLRIk0JGGGbM7rs3drkEmNunGpqrMo t8PLRsoDctzan1oTs4ysN3cLVpXLdzRE8xBPYL2bTUoLXq8t5iRgHQpNZm07JmDG3xlY fUde73e67gC4ytLattpyOUvMNAxFIZe0n/Bo4K/K0X8mI52RyVUplO8XLsxB4S0puJeq 1L9iJB5v64rhdvsJGXFES4c1R5W99SPV7rdJsTd3LBWL6LGaEzWLSTLjzMUSoauglyYY Xp14Lo5nKiBPQB3FB6O2FZJxVUfDisdJtpIDTQhQev77Q+MY8XTSizAKzS55HXccl3q8 gxiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fo3EUWHJT1j3yLuNTbHIXcTfIN9vSPE887EDP3zLYe0=; b=lqbBwC4A57jvQgiIwMiBLHJJ8/McJMQInpB6eDk74t4Hf1zUK90l6EJVDZh/Rv3BZ8 VqB8fKEjqXsUxYwK/Ty8wWnefZ3dzQLSPVDsSw/zW9sMO+yr2628e5/2f0D103hFXsAC whC7cCZGzNYUmd8HQUMigf7ItbUQwIlbjjJJHXc9x2Jw8pWY7SAJ5djwcCOwzIIvmmRj ppgtwD40lOh+vgGV3jLgV165W8YQ+KL7Js9Q0LNlw9d0O8LjybErTXFzKfg4ITbZmVZQ 7n7CniqhhrpGl5CcJLU8Jm9BIfoRxKf+wlOkTWceUtSiaf55zEinJTW3hEyQ2xAQQ0Ti KaKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kYcHfAIn; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r194si2697293oie.66.2020.03.27.13.57.19; Fri, 27 Mar 2020 13:57:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kYcHfAIn; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727549AbgC0Uzm (ORCPT + 99 others); Fri, 27 Mar 2020 16:55:42 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:32946 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgC0Uzm (ORCPT ); Fri, 27 Mar 2020 16:55:42 -0400 Received: by mail-oi1-f196.google.com with SMTP id m14so10082657oic.0 for ; Fri, 27 Mar 2020 13:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fo3EUWHJT1j3yLuNTbHIXcTfIN9vSPE887EDP3zLYe0=; b=kYcHfAInHHKIf1i98mn3uB03/rGIJzwgBGtTm+OOf8s8lnzyElYDh/ErhrKQxv/0ps ci6gpmRXRMdkyzGn7wPISUbGfUvnZ2iJEf15aQoMSyPCetsZlptGmGwNA1wwtw2W+Df0 LdCLnclA2VJf9rjhb1iynBQfqsHzMkYboWm9BLpdKN0Ucj1lJe5i+xyKXEystjgTwJ5x 4W0J0tXMPMVGzr4WMW1QY+fIZBRGsI798kTLASAE5q6w5kKYOcCbJfszyYu9ZOqf3Tkr Ywvc5pkFiMean4Y3XknRkuI/DycMvUngM4RgB955qEmUUk6tpqNR5Zu4lZM077/hMNIJ x19g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fo3EUWHJT1j3yLuNTbHIXcTfIN9vSPE887EDP3zLYe0=; b=IcackBMu4KoJdBJKJTIVtGs8Xgz7iMVHRds2ammnX7xoqDTfQ1f+z1ybwfqhEO7nX8 WVpcmkH1S3/OdW5PqWYZn5X+RSmhV57VbhUD4+auRWosJCX38NrTy5eLEBWSz/VzCdxg kQwsa8JVV6nWwUFz2DxGReXfiTxPCCNSXe+HK7T4vWI6NlbGMrZcGH35nzMWnkfy5CQw +hUmgzjGDNT/9+5rat/t3178ESk+s3ltQI5L+9RewNj4oTSEHxmXGvxqKihQW8zfTs3s 59/OuB6BXOrfKeZIlp+rGdCzfUqCcE6VLy2TUGHhz2GM5dWoGM6qvprUjvAd1SJT1pX4 owYw== X-Gm-Message-State: ANhLgQ07+uR5Y3pfdD7ITX2Of3ds0zfUgZMmsf1lAf/LVX3dKwtSO756 DpzD6pYe+viCfZGHdS5GFYSSsX4GbQjWpe+2u277ag== X-Received: by 2002:aca:5345:: with SMTP id h66mr622078oib.110.1585342541082; Fri, 27 Mar 2020 13:55:41 -0700 (PDT) MIME-Version: 1.0 References: <20200320131356.Bluez.v1.1.Ia3d21e293d18f903fa6e54918856e1dd5ffc904f@changeid> In-Reply-To: From: Luiz Augusto von Dentz Date: Fri, 27 Mar 2020 13:55:28 -0700 Message-ID: Subject: Re: [Bluez PATCH v1] avdtp: fix delay report valid states To: Archie Pusaka Cc: linux-bluetooth , Archie Pusaka Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Archie, On Thu, Mar 26, 2020 at 7:14 PM Archie Pusaka wrote: > > [re-sending as plain text] > Hi Bluez Maintainers, > > Could you take a look at this proposal? > > Thank you! > > > On Fri, 20 Mar 2020 at 13:14, Archie Pusaka wrote: > > > > From: Archie Pusaka > > > > According to AVDTP specification section 6.19, > > avdtp_delayreport_cmd could also be received when the state of SEP > > is open. > > > > Therefore, updating to accommodate such condition. > > --- > > > > profiles/audio/avdtp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c > > index 0e075f9ff..4b0e63384 100644 > > --- a/profiles/audio/avdtp.c > > +++ b/profiles/audio/avdtp.c > > @@ -1936,6 +1936,7 @@ static gboolean avdtp_delayreport_cmd(struct avdtp *session, > > stream = sep->stream; > > > > if (sep->state != AVDTP_STATE_CONFIGURED && > > + sep->state != AVDTP_STATE_OPEN && > > sep->state != AVDTP_STATE_STREAMING) { > > err = AVDTP_BAD_STATE; > > goto failed; > > -- > > 2.25.1.696.g5e7596f4ac-goog > > Applied, thanks. -- Luiz Augusto von Dentz