Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200312100754.3445-1-sathish.narasimman@intel.com> <CAOVXEJJK0WgeXvwPM=_7kUxrb7O13E5XcaNDpURC6acwrGgXWg@mail.gmail.com>
In-Reply-To: <CAOVXEJJK0WgeXvwPM=_7kUxrb7O13E5XcaNDpURC6acwrGgXWg@mail.gmail.com>
From:   Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Date:   Wed, 1 Apr 2020 13:04:32 -0700
Message-ID: <CANFp7mUpEwwKCw6xsGWzRXH7q+ZPBJPJaG8n53UsSFd0yfnSzw@mail.gmail.com>
Subject: Re: [PATCH 0/7] LE LL Priavcy support enabled
To:     Sathish Narasimman <nsathish41@gmail.com>
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Sathish Narsimman <sathish.narasimman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Satish,

Looking through the patches in this series, it looks like you are
adding the IRK for all connected devices and I'm not sure that's the
best method.
The resolv list seems to be useful in the same way as the le
whitelist: to filter incoming advertisements for devices we care
about.

Thus, to simplify your design, could we not do the same thing as the
le whitelist:
* Update the resolv list anytime passive/background scan is being enabled
* Only keep entries in the resolv list that are part of the
pend_le_conn or pend_le_report lists

Then, you would only need to update the resolv list in
hci_req_add_le_passive_scan and any IRK changes would just disable
passive scan, remove IRKs if existing and re-enable passive scan
(which would add it back with the new one).

Thanks,
Abhishek

On Wed, Mar 18, 2020 at 1:56 AM Sathish Narasimman <nsathish41@gmail.com> wrote:
>
> Hi
>
> A gentle reminder to review the patches
>
> On Thu, Mar 12, 2020 at 3:36 PM Sathish Narsimman <nsathish41@gmail.com> wrote:
> >
> > With this LE LL Priavcy feature available if BT controller supports
> > LL Privacy when privacy is enabled.
> >
> > The patches are verified in below case.
> > Pairing - where the IRK is added to device Resolving List after
> > identity info & IRK is shared in SMP.
> > Unpair - Delete the resolving entry from the Device resolving list
> > Local IRK change - Whenever there is change in local IRK (privacy) the
> > resolving list entries in the device is updated.
> > Whitelist - filter policies for whitelist is updated based on LL_adress
> > resolution support.
> > Reload Resolving list - device reset/sysmte reboot the Resolving list
> > reloaded in to the device.
> >
> > Sathish Narsimman (7):
> >   Bluetooth: LL Privacy Delete Store Resolving list
> >   Bluetooth: Add device to Resolving List
> >   Bluetooth: Update the Resolving list when Local IRK changed
> >   Bluetooth: LL_PRIVACY re-load resolving list
> >   Bluetooth: LL Privacy Check and Update the Resolving List
> >   Bluetooth: Enable LL Privacy
> >   Bluetooth LL Privacy update White list
> >
> >  include/net/bluetooth/hci.h      |   3 +
> >  include/net/bluetooth/hci_core.h |   7 +
> >  net/bluetooth/hci_conn.c         |  32 ++++
> >  net/bluetooth/hci_core.c         |  20 ++-
> >  net/bluetooth/hci_event.c        |  32 +++-
> >  net/bluetooth/hci_request.c      | 251 ++++++++++++++++++++++++++++++-
> >  net/bluetooth/hci_request.h      |   2 +
> >  net/bluetooth/mgmt.c             |  10 +-
> >  net/bluetooth/smp.c              |  11 ++
> >  9 files changed, 354 insertions(+), 14 deletions(-)
> >
> > --
> > 2.17.1
> >