Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Mime-Version: 1.0
Subject: RE: Re: [PATCH BlueZ] mesh: Add check for valid netkey index
Reply-To: anupam.r@samsung.com
From:   Anupam Roy <anupam.r@samsung.com>
To:     "Gix, Brian" <brian.gix@intel.com>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
In-Reply-To: <3aa08d9a552ab02b0495b2a3970405ee082c85de.camel@intel.com>
Message-ID: <20200403052925epcms5p297a218e7780438e3db945d8007000b2f@epcms5p2>
Date:   Fri, 03 Apr 2020 10:59:25 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <3aa08d9a552ab02b0495b2a3970405ee082c85de.camel@intel.com>
        <9038a2fe4daafd90def2444d71c8914c6a64a688.camel@intel.com>
        <82b707704e1863c43748adce03057d2252fea59a.camel@intel.com>
        <1585740006-9569-1-git-send-email-anupam.r@samsung.com>
        <20200402140519epcms5p3608d451804bf03eefc34ce77b04ab0aa@epcms5p3>
        <20200402160037epcms5p5c94d5798e7611c11e795c51bc39b5a6b@epcms5p5>
        <CGME20200401112015epcas5p10545143f69c22449f559818476845cc5@epcms5p2>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Brian,
>On Thu, 2020-04-02 at 21:30 +0530, Anupam Roy wrote:
>> Hi Brian,
>>=20
>> > You are correct in finding this bug...  It was found in paralell by Pr=
zemys=C5=82aw=20Fierek,=20and=20should=20be=20fixed=0D=0A>>=20>=20as=0D=0A>=
>=20>=20of=20this=20commit:=0D=0A>>=20>=20=0D=0A>>=20>=20=20=20commit=2084a=
9b6ce4b66a2ba21cce8e4b0c3c6e097a5493a=0D=0A>>=20>=20=20=20Author:=20Przemys=
=C5=82aw=20Fierek=20<przemyslaw.fierek=40silvair.com>=0D=0A>>=20>=20=20=20D=
ate:=20=20=20Tue=20Mar=2031=2014:09:08=202020=20+0200=0D=0A>>=20>=20=0D=0A>=
>=20>=20=20=20=20=20=20=20mesh:=20Add=20net=20key=20index=20to=20sar=20stru=
cture=0D=0A>>=20>=20=20=20=20=20=20=20=0D=0A>>=20>=20=20=20=20=20=20=20This=
=20patch=20adds=20net=20key=20index=20to=20struct=20mesh_sar.=20This=20fixe=
s=20problem=20with=0D=0A>>=20>=20=20=20=20=20=20=20using=20invalid=20networ=
k=20key=20to=20encrypt=20application=20messages.=0D=0A>>=20>=20=0D=0A>>=20>=
=20=0D=0A>>=20>=20If=20you=20check=20out=20the=20current=20tip,=20hopefully=
=20it=20will=20solve=20the=20problem=20you=20found=20where=20the=20incorrec=
t=0D=0A>>=20>=20(primary=0D=0A>>=20>=20subnet)=20key=20was=20used=20instead=
=20of=20the=20requested=20net=20key.=0D=0A>>=20>=20=0D=0A>>=20Okay,=20got=
=20it,=20thanks.=0D=0A>>=20Since=20we=20plan=20to=20use=20the=20net=20key=
=20index,=20will=20the=20below=20sanity=20check=20stand=20valid(in=20case=
=20of=20app_idx=20=3D=3D=0D=0A>>=20APP_IDX_DEV_REMOTE)?=0D=0A>>=20As=20it=
=20may=20save=20some=20un-necesary=20processing=20of=20the=20message=20payl=
oad=20in=20case=20net=20key=20index=20is=20*Not*=20valid=20or=0D=0A>>=20*su=
bnet*=20is=20deleted=20by=20Config=20Client.=20Please=20share=20your=20opin=
ion.=20Thanks=0D=0A>=0D=0A>If=20the=20App=20uses=20DevKeySend()=20with=20re=
mote=20=3D=3D=20true,=20but=20the=20node=20does=20not=20have=20the=20device=
=20key=20for=20that=20remote=0D=0A>node=20in=20it's=20keyring,=20the=20meth=
od=20will=20silently=20fail,=20and=20no=20message=20will=20be=20sent=20Over=
-the-Air.=0D=0A>=0D=0AOkay,=20I=20got=20that,=20deleting=20the=20keyring=20=
(by=20subnet-delete=20<net=20idx>)=20should=20not=20have=20any=20effect=20f=
or=20remote=20DevKeySend=20messages,=0D=0Aas=20net=20idx=20would=20be=20use=
d=20just=20to=20pick=20up=20Network=20Encryption=20Key=20from=20the=20node-=
>net->subnet.=20Thanks=20for=20clarification.=0D=0A=0D=0A>If=20the=20App=20=
wants=20to=20*respond*=20to=20an=20incoming=20command=20received=20with=20t=
he=20local=20nodes=20device=20key,=20it=20should=0D=0A>respond=20using=20De=
vKeySend()=20with=20remote=3D=3Dfalse,=20and=20net_index=20=3D=3D=20the=20n=
et_index=20from=20the=20cooresponding=0D=0A>DevKeyMessageReceived().