Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] tools/hciattach_ath3k: Load BT board data based on
 country code
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200331003355.14614-1-sonnysasaka@chromium.org>
Date:   Fri, 3 Apr 2020 15:53:25 +0200
Cc:     linux-bluetooth@vger.kernel.org, yixiang@google.com,
        caiz@google.com
Content-Transfer-Encoding: 8BIT
Message-Id: <7CA6DAE1-09E7-4CEC-BA78-E8C4E104D92E@holtmann.org>
References: <20200331003355.14614-1-sonnysasaka@chromium.org>
To:     Sonny Sasaka <sonnysasaka@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Sonny,

> BT board data file PS_ASIC-<country-code>.pst is loaded based
> on country code. If not exist, default BT board data file
> PS_ASIC.pst would be loaded.
> 
> This patch doesn't define how to get the country code at the moment, but
> future patches can supply the country code in the region parameter of
> get_ps_file_name.
> ---
> tools/hciattach_ath3k.c | 32 +++++++++++++++++++++++---------
> 1 file changed, 23 insertions(+), 9 deletions(-)

while we can fix parts of hciattach, but I rather remove that tool at some point.

Do you still require it with serdev kernel support? I mean all UART based Bluetooth controllers should be handled via serdev.

Regards

Marcel