Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200331003355.14614-1-sonnysasaka@chromium.org> <7CA6DAE1-09E7-4CEC-BA78-E8C4E104D92E@holtmann.org>
In-Reply-To: <7CA6DAE1-09E7-4CEC-BA78-E8C4E104D92E@holtmann.org>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Fri, 3 Apr 2020 09:41:28 -0700
Message-ID: <CAOxioNm27+wmWeCp+hoWCF-5W1=xm_gdvn3xWbDJVeYE=wmyiQ@mail.gmail.com>
Subject: Re: [PATCH] tools/hciattach_ath3k: Load BT board data based on
 country code
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>, yixiang@google.com,
        Zhifeng Cai <caiz@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

Thanks for your feedback. I will take note of this deprecation plan.
For now, Chromium OS can have a local patch to accomplish this and in
the future we will migrate to serdev instead of hciattach.

On Fri, Apr 3, 2020 at 6:53 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > BT board data file PS_ASIC-<country-code>.pst is loaded based
> > on country code. If not exist, default BT board data file
> > PS_ASIC.pst would be loaded.
> >
> > This patch doesn't define how to get the country code at the moment, but
> > future patches can supply the country code in the region parameter of
> > get_ps_file_name.
> > ---
> > tools/hciattach_ath3k.c | 32 +++++++++++++++++++++++---------
> > 1 file changed, 23 insertions(+), 9 deletions(-)
>
> while we can fix parts of hciattach, but I rather remove that tool at some point.
>
> Do you still require it with serdev kernel support? I mean all UART based Bluetooth controllers should be handled via serdev.
>
> Regards
>
> Marcel
>