Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] tools/hciattach_ath3k: Load BT board data based on
 country code
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CAOxioNm27+wmWeCp+hoWCF-5W1=xm_gdvn3xWbDJVeYE=wmyiQ@mail.gmail.com>
Date:   Fri, 3 Apr 2020 18:56:01 +0200
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>, yixiang@google.com,
        Zhifeng Cai <caiz@google.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <CC80769E-941D-4AD9-AFB3-C24DD84E940D@holtmann.org>
References: <20200331003355.14614-1-sonnysasaka@chromium.org>
 <7CA6DAE1-09E7-4CEC-BA78-E8C4E104D92E@holtmann.org>
 <CAOxioNm27+wmWeCp+hoWCF-5W1=xm_gdvn3xWbDJVeYE=wmyiQ@mail.gmail.com>
To:     Sonny Sasaka <sonnysasaka@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Sonny,

> Thanks for your feedback. I will take note of this deprecation plan.
> For now, Chromium OS can have a local patch to accomplish this and in
> the future we will migrate to serdev instead of hciattach.

I can apply the patch if you are still using it, but be aware of that fact that we are going to kill hciattach latest when we move to the 6.x major version number.

Using serdev is a lot better, cleaner and simpler in the end. So I would urge to make that change rather sooner than later.

In addition, I would really like to kill hci_uart.ko driver as well. That one has become a beast with a bunch of hacks that will eventually backfire. Since we have serdev now, I think each vendor should get their own driver. I have posted examples to btuart.ko and bt3wire.ko drivers that could be used as base.

Regards

Marcel