Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp739131ybb; Fri, 3 Apr 2020 10:55:22 -0700 (PDT) X-Google-Smtp-Source: APiQypJ/VMsaJsZctNswSP8wM+bfhJrb0Y20i1JpfcocjOdWCs6GjDn/OBnDtmK3lNIQ8zDZhWN7 X-Received: by 2002:a9d:5c82:: with SMTP id a2mr7760140oti.22.1585936522191; Fri, 03 Apr 2020 10:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585936522; cv=none; d=google.com; s=arc-20160816; b=t84sqv0GyP67aLYkEAhba2Xx3DZSuQUi2GyqGTQP7V5mb/kojneUSXCfpsQUrisGvu jiduZJNwEFO2kg3Ag4KtoVuZC9SG3vEIdwdwi/Y+GIosDQXdHqk5+JzcH0FTRQ14+wMi Vu9Mk6Ed/oBgceW369fXchkm3hWgQX27PyKrk4SATJhC9dy880TAjJkbzw22BNhtiIYb iaUUgWxBp6QN13DMsn6IL7cV4YNgpyc6G9we1FlYb63A1INowbcIs1mqqE52WbJ0TS1+ tX+iwj0VQlOVfgLJG3f1FrdDQ+MnA4VXKblc9emr5DSoHEhACOvs4m8xQDfep38LOZAz 9oAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=skLv1HRTtKpr2smpOIuKaE2HQF8dZkc8tbEnmioJS3g=; b=doejZrnHbrE1UQMNVjg20sKwdIqQAv+k1dfeCvcdKvDTTwvp/95db52cQ5Mk32l1pE SETpLInz43KlQq5cMCPuJYFe5/LFcqRScgFnxvvZyyURJW/bnRXCKyUnFMLzsk6SyIei c5d7uiQwUszjjiV766Mz4auyHdd8kmzkg4e020dBGZ/JMIgG/zwiNSAXNv4mmuPrUIyK XlGc7czanFA6jONMN6cqNIGgRf0xC7RkQKw+FthjKuZhNQOKQV3ipUze/fn3J3ow56Pu 5Hk26uxh5PCn/rY+gnklMN9CpocGAbyQ5SGbZ4ja2evMJwVmifVHxJGhuAdhTDuibRtk 0WUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=Cjl+5zIx; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l11si3939789oop.3.2020.04.03.10.55.08; Fri, 03 Apr 2020 10:55:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=Cjl+5zIx; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728342AbgDCRyI (ORCPT + 99 others); Fri, 3 Apr 2020 13:54:08 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:36993 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727167AbgDCRyI (ORCPT ); Fri, 3 Apr 2020 13:54:08 -0400 Received: by mail-lj1-f193.google.com with SMTP id r24so7855094ljd.4 for ; Fri, 03 Apr 2020 10:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=skLv1HRTtKpr2smpOIuKaE2HQF8dZkc8tbEnmioJS3g=; b=Cjl+5zIxMaI090z+bEa1QuAUQ/TE05boar4TaWarwzjr4irQoAG6MBBeGZ7mEkAc0n gb+wIOXbmfIhJDJgSbLYu+hqtID8b2adiNwFJGXZ7+1/6dErnDKruievB5y5nzz0DQIA 4g3oc3GkKEdiojpW2DLfCHuRVju0sf3pJw7gea2QJpO7oigpNIp2OXLVo6GxlYhbbJ0I Lt2JO1OReVBPE2yfRD3itR6TzQljidwQKm+EQtNXk2iPyTviYJOz4C3JwecBRXC17j43 IH1AUSKPiZ/STZzfna0IVaXQA2oV3EyMvaln0uL7fOyMPW+jCvkf3AG61wcau7dJhmhU YZXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=skLv1HRTtKpr2smpOIuKaE2HQF8dZkc8tbEnmioJS3g=; b=bQ45DhXGlIJLut41daaEFs1sG+KJvhmdZUVxSF0NSIXM8Yq11gJLC+9vi4aMQB2Aw5 h9/jjWwjdLYfT20L31FDteAPayonpwpsKfuOGIhzo7xcfgkLVeg1UCm7aXsL9NpzCLef 22yKyKPrwtxILOlfW97ZWXa/XfjfHWsJLnwiQnPRmzQGdVXAYnGkKibocGScJ4zupYOH ahSmeCd2YGBj27g40Lzw9SGPFQpUDLNdzcEgu2+1v3P7DOQ+Pes69Nf4PesED0+lg+8s oY7YnAOsf2gixIaBKXoSc5qp+8x2ANKrAuuJrwM9HSdXEMe3d0dWSfzj1dh5QpmaKZQq K0hg== X-Gm-Message-State: AGi0Pub29Ah4vOXhyhSQKq+YKz8jSq97vRVJyixUk5hSyqWRxMAXAbJz DT23aybYyMUN9KHMBMa3uXY1BEvVFcM= X-Received: by 2002:a2e:b1c2:: with SMTP id e2mr5803983lja.288.1585936444666; Fri, 03 Apr 2020 10:54:04 -0700 (PDT) Received: from kynes (apn-37-7-76-34.dynamic.gprs.plus.pl. [37.7.76.34]) by smtp.gmail.com with ESMTPSA id n23sm5213183lji.59.2020.04.03.10.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 10:54:04 -0700 (PDT) Date: Fri, 3 Apr 2020 19:54:02 +0200 From: =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek To: linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com Subject: Re: [PATCH BlueZ RESEND] mesh: Remove redundant code from mesh/crypto Message-ID: <20200403175402.xto4ub6w6uqqyfz4@kynes> Mail-Followup-To: linux-bluetooth@vger.kernel.org, brian.gix@intel.com References: <20200326211705.18678-1-michal.lowas-rzechonek@silvair.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200326211705.18678-1-michal.lowas-rzechonek@silvair.com> Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Brian, On 03/26, Michał Lowas-Rzechonek wrote: > - Remove application_encrypt/application_decrypt > - Make mesh_crypto_privacy_counter private, add mesh_crypto_pecb > - Make *_nonce functions private and align their implementation to be > more consistent > - Refactor network_encrypt/network_decrypt to use *_nonce functions and > rename them to packet_encrypt/packet_decrypt > - Refactor packet_encode/packet_decode Ping... This version of the patch passes unit tests. I'd really like to get this applied. Or at least tell me straight in the face that I should bugger off ;) regards -- Michał Lowas-Rzechonek Silvair http://silvair.com Jasnogórska 44, 31-358 Krakow, POLAND