Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp739515ybb; Fri, 3 Apr 2020 10:55:52 -0700 (PDT) X-Google-Smtp-Source: APiQypKSt5TSOjcRKCUhT2fSNRpMb7Pxqk3uPUYuTwoQ+9NoBr7Ae6ThALiA1ZiGmm7BeJOMpoDl X-Received: by 2002:a05:6830:1f56:: with SMTP id u22mr7622649oth.55.1585936552634; Fri, 03 Apr 2020 10:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585936552; cv=none; d=google.com; s=arc-20160816; b=Eg+DwpC9JfpSZqzqv2uOttc2ygkPMrEKLmruFULE2pBxpjO+J4ym0cDxWWONNlpotY t8qNEIBl3M1IaPdEEGdQ6GfZeG9qPy0vxFYidJP1FgdaYsCPczgrHveXMtC5WlZ80deX zvBaEm7A3nBabIrTOObk9Jf3HK50Gu7bJUbiicBPXYriWyj0NCYDsM2LOgxEUk4dR8/b rrJIoRQlU1PevhUUBZTaIA7m3tqdDRZt9F4JHIWwDtDIrAmcHG7r4s/sOgK+GVMbYlvx Y+2grbuugsdFO0at1oxf+pnAFEH+gXoZjpcy8c/eGRCjin8pCs2trNNhUUHbzs9svbRC qt0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=6Y3JmRrd9MRUQqES6MNU+fEjUp4DvXrw8BTG4ou0rQQ=; b=SMaj64AJYCQ/Qpku5K9Q7eaCjo+eL3QeF0nLO7cIV4fHjrtgwxDKi+p5T+QqNT6rDn VxTZV7kETnUK3qPDZt5ynQTjQ1Axg8cvzlsyKaC0+D8ZM3rqSfAosZ2r9jhTcLc3w5ME LxqLwrx03DyuJeOo8BprG/6ZbQqgkzYaDCFsS1pyNQxHZSiegC2lm2S22V2pWlydubl6 kUhsGWQ5+lBcGFJsmVmeDoRGuf82KdziDAY4dccVlMEoW4ZTcjySmkNnzhYbA/KKWHqo 8ZWxYHldEafbC3pPeZgpxExO2xk1CT/slWw3J4Hjhu517lFB0bH1zF35y6lykdZ5LyLZ N51A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=lEnnCs0x; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r205si4046228oig.174.2020.04.03.10.55.39; Fri, 03 Apr 2020 10:55:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=lEnnCs0x; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403948AbgDCRzB (ORCPT + 99 others); Fri, 3 Apr 2020 13:55:01 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:43071 "EHLO mail-lj1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727167AbgDCRzB (ORCPT ); Fri, 3 Apr 2020 13:55:01 -0400 Received: by mail-lj1-f171.google.com with SMTP id g27so7795901ljn.10 for ; Fri, 03 Apr 2020 10:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6Y3JmRrd9MRUQqES6MNU+fEjUp4DvXrw8BTG4ou0rQQ=; b=lEnnCs0xYcyNcPHPp/UKrQ1XoCask9TB9Z/wQK75vKphRvQu74GYprmSjDgi23xHCA 8LnEB6GA5+DFPHSsDZWMX1H5o5m0Z/WNNgV07Rvo9MEu/KoJobt4QNu+rRwp0XSzPQzD k4vFXejCw9a5ka0k+1A32hZI61L7rk7dJC8LYx33V6wtT0hdGnHa5zpbmpqSsBvqsFef sV0LJ9vpzi9rfz8ohkkZsddIFyk1zdykhtesqsRmIsgYrskOqn/KwPX2nHYaEe1rv/uW Ip+tagAYteoU84wVHB3lFWCZEKV0KRUqG4hA23EhYstPbFTNFcE5eHh//PIBz7JS1siO Vjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=6Y3JmRrd9MRUQqES6MNU+fEjUp4DvXrw8BTG4ou0rQQ=; b=j09sNTkjRVVz/poK+XqO5ImzqecVKX0XYpB8aXku6ilT3yCNL/6B+sU2lfea6/DrbN wajCr1P6J3cjY+HpKHEr/6dBY1JwHctO5im2z+VnKZU/XudHi4rK6WWdeCSptRlZ+Fd8 cZYHk73sWRpFwzEoqY7gj6R1NJWm3Ete4y+9BPmXC/mxXTWZ+YU0lfOIBTIz4B0z3rfx HD6AThmZHulZwg/+VqHmCzIOVJBS8beNINWSN4xRxeZPQKWdGScpK56NpLgZ71dl8C5d Oo4+iKzw7ovpNCMAEhz5yqGe8NB6Wjc6xmtB7yZctkfGk7Q02H3yulzzAJyGuqXJp3Qs buvw== X-Gm-Message-State: AGi0PubyZfeyBVu/PtfiL8Q3z0jZ9yP3tThT8Bq+kNMUTorp18MZNnwp mhEV5kk0NQrltyRrFsf1qvuy7yMlcfY= X-Received: by 2002:a2e:9886:: with SMTP id b6mr5617139ljj.237.1585936498367; Fri, 03 Apr 2020 10:54:58 -0700 (PDT) Received: from kynes (apn-37-7-76-34.dynamic.gprs.plus.pl. [37.7.76.34]) by smtp.gmail.com with ESMTPSA id b25sm1242628lff.0.2020.04.03.10.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 10:54:57 -0700 (PDT) Date: Fri, 3 Apr 2020 19:54:56 +0200 From: =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek To: linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com Subject: Re: [PATCH BlueZ v2] mesh: Fix FPE in overcommit logic. Message-ID: <20200403175456.cnw6dz4gywwq6xte@kynes> Mail-Followup-To: linux-bluetooth@vger.kernel.org, brian.gix@intel.com References: <20200331090400.18379-1-michal.lowas-rzechonek@silvair.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200331090400.18379-1-michal.lowas-rzechonek@silvair.com> Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Brian, On 03/31, Michał Lowas-Rzechonek wrote: > During overcommit, mesh_config_save is called in asynchronous mode to > avoid blocking Send() calls. This means that update of cfg->write_time > is scheduled via l_idle_oneshot, so if the next Send() gets scheduled > first, the code may see elapsed time of zero. > > If this happens, then the overcommit logic was already executed and the > overcommit is pending, so we can just return. Ping? -- Michał Lowas-Rzechonek Silvair http://silvair.com Jasnogórska 44, 31-358 Krakow, POLAND