Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v7 2/2] bluetooth:btusb: handle msbc audio over USB
 Endpoints
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CAOVXEJJRvzsWjTL4Z7eLyqfjFPb7rMXmHnqp_Ux7ZvnyXMMEGg@mail.gmail.com>
Date:   Mon, 6 Apr 2020 13:51:59 +0200
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Sathish Narasimman <sathish.narasimman@intel.com>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Hsin-Yu Chao <hychao@chromium.org>,
        Amit K Bag <amit.k.bag@intel.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <65A96C2C-C2A7-4B93-B015-EACB623A0B18@holtmann.org>
References: <20200402152758.10363-1-sathish.narasimman@intel.com>
 <20200402152758.10363-2-sathish.narasimman@intel.com>
 <59EE263D-87B2-42E0-A5EA-9F261BAC29BC@holtmann.org>
 <CAOVXEJJRvzsWjTL4Z7eLyqfjFPb7rMXmHnqp_Ux7ZvnyXMMEGg@mail.gmail.com>
To:     Sathish Narasimman <nsathish41@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Sathish,

>>> For msbc encoded audio stream over usb transport, btusb driver
>>> to be set to alternate settings 6 as per BT core spec 5.0. The
>>> type of air mode is used to differenting which alt setting to be
>>> used.
>>> The changes are made considering some discussion over the similar
>>> patch submitted earlier from Kuba Pawlak(link below)
>>> https://www.spinics.net/lists/linux-bluetooth/msg64577.html
>>> 
>>> Reported-by: kbuild test robot <lkp@intel.com>
>>> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
>>> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
>>> Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
>>> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
>>> ---
>>> drivers/bluetooth/btusb.c | 155 +++++++++++++++++++++++++++++---------
>>> 1 file changed, 118 insertions(+), 37 deletions(-)
>> 
>> I decided to look at these to patches and fix up a few things.
>> 
>> 1) Use conn->setting & SCO_AIRMODE_MASK to select the option and with that also ensure that we don’t send this for ulaw and alaw air modes if they ever get established (even if unlikely).
>> 
>> 2) Fix a bunch of coding style violation
>> 
>> Please test these two patches if they still work according and then I can apply them.
>> 
>> Regards
>> 
>> Marcel
>> 
> Tested these 2 patches and they are working fine

good since Johan already applied them to bluetooth-next tree.

Regards

Marcel