Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 Apr 2020 21:37:34 +0200
From:   "michal.lowas-rzechonek@silvair.com" 
        <michal.lowas-rzechonek@silvair.com>
To:     "Gix, Brian" <brian.gix@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ RESEND] mesh: Remove redundant code from mesh/crypto
Message-ID: <20200406193734.sf4s22b7uvcm4c7o@kynes>
Mail-Followup-To: "Gix, Brian" <brian.gix@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
References: <20200326211705.18678-1-michal.lowas-rzechonek@silvair.com>
 <27728473092a638d6c97520b14eac61656c56903.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <27728473092a638d6c97520b14eac61656c56903.camel@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Brian,

On 04/05, Gix, Brian wrote:
> I think this needs some more work, in that it no longer correctly
> fails the mesh-test-crypto test when running:
> 
> make distcheck
> 
> It *almost* does in that it flags an error in red if a "verify" step
> fails, but it does not exit with a fail code.  This is an important
> step, particularily with the dependance on kernel based crypto
> functions.
> 
> My test methodology was to flip a bit in one of the test payloads
> (i.e., make it "not perfectly match" the specification sample data).
> 
> As best I can tell, it is otherwise functional, but the unit tests are
> important.

Agreed, but as of 14301cf0d42ba3fc4de99c3bdf183045be733e0c running
unit/test-mesh-crypto with modified payloads, e.g.

diff --git a/unit/test-mesh-crypto.c b/unit/test-mesh-crypto.c
index 0043b0b10..a832b2000 100644
--- a/unit/test-mesh-crypto.c
+++ b/unit/test-mesh-crypto.c
@@ -591,7 +591,7 @@ static const struct mesh_crypto_test s8_3_11 = {
 static const struct mesh_crypto_test s8_3_22 = {
        .name           = "8.3.22 Message #22",
 
-       .app_key        = "63964771734fbd76e3b40519d1d94a48",
+       .app_key        = "63964771735fbd76e3b40519d1d94a48",
        .net_key        = "7dd7364cd842ad18c17c2b820c84c3d6",
        .dev_key        = "9d6dd0e96eb25dc19a40ed9914f8f03f",
        .iv_index       = 0x12345677,

also does not cause it to exit non-zero return code, it just prints red
"FAIL"s...

I thought it was done on purpose, as mesh tests don't seem to use the
src/shared/tester.h.

Also, after applying the patch onto the mentioned commit, I'm getting
all green runs. What system are you using? I'd like to try reproducing
your results.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND