Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp295719ybb;
        Tue, 7 Apr 2020 23:16:27 -0700 (PDT)
X-Google-Smtp-Source: APiQypITsyJf9mnMCQ8T4paIlqssy2EFteP0v/bqCAz69NKgeQdhUMrMqlYif0J7VP4ETZna4wAW
X-Received: by 2002:a05:6808:8f:: with SMTP id s15mr1371173oic.110.1586326587340;
        Tue, 07 Apr 2020 23:16:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1586326587; cv=none;
        d=google.com; s=arc-20160816;
        b=URld7Y4ChRsISqGe50RrWhpRyZ+Q0iL6DHl4EAJrZYsp1v22yEUEbG6VRBmYlS/eTo
         TkKZPksiEz0zh8tdwh2BJ3frIz7iuen1xegjGGFDoRUaA1SrD+GyuTCFyltnJSFGWXU2
         bP8QXOmVm3h+izs40Rwlj/i88GgILF2LlmdcP3MypbyvFbCKicaoHStw9CYBuiav2Oie
         l0+8HWOhhRplmxPpgJ4eC2pPP1Y6qb5OMixLjx8+U3iUdpn4KIbnM1srUzDJZaCT5cSr
         jp+nMwjVsQR8SyUnnmNOaoBLA8GF303hsq5cZe8MwcjTrJbpVc9VJ8SbOY3WjCFissvj
         HGfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:to:references:message-id
         :content-transfer-encoding:cc:date:in-reply-to:from:subject
         :mime-version;
        bh=2UMl27hVNjNXjzgexDbJLzqcWgckAQBJlRznTGsZHtU=;
        b=t1MRUrspqwNBactaX/olvPd5g+DOLM9VhQeUXZZ3fDz96/ruf0lcSdoZdJWrSDO5rJ
         Pr68NNuUmcn0NiHxTq9lpLfxKUvKpHLQggNSJdNRWPXUFgfTpXep6lXKrMwYc+F2birt
         zufB0fo0hMyfMQGAtDVIhm9u/Izxf/zTUrMQLRKQk+IOeLzJFxt502qmFv/Oatkh54eh
         iErkvU22Ah/2NGJK+IZU+LpUNk6HV+zMkS1VEq5PlPOFw5L5w8FRferdnHp0krU4WGMc
         fWJTUuGfwgN0SerXmzVE+A6LSpl9ERD5SIMFofga5APYi74Oa8sNbqB+j3lcvHGJ5TNR
         K2iw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org
Return-Path: <linux-bluetooth-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a66si2000673otc.172.2020.04.07.23.16.00;
        Tue, 07 Apr 2020 23:16:27 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726477AbgDHGNl convert rfc822-to-8bit (ORCPT
        <rfc822;rlubas@gmail.com> + 99 others);
        Wed, 8 Apr 2020 02:13:41 -0400
Received: from coyote.holtmann.net ([212.227.132.17]:43559 "EHLO
        mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726467AbgDHGNk (ORCPT
        <rfc822;linux-bluetooth@vger.kernel.org>);
        Wed, 8 Apr 2020 02:13:40 -0400
Received: from marcel-macbook.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167])
        by mail.holtmann.org (Postfix) with ESMTPSA id 3E73BCECE0;
        Wed,  8 Apr 2020 08:23:13 +0200 (CEST)
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v3] Bluetooth: Configure controller address resolution if
 available
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CANFp7mVSQEOyT7GrOa4NhAGozt5SMx3yU_ma6tav5bJ8GXJn8w@mail.gmail.com>
Date:   Wed, 8 Apr 2020 08:13:38 +0200
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <1FE78D4A-E6EC-440C-B76E-82F75D615D92@holtmann.org>
References: <20200407205217.1002534-1-marcel@holtmann.org>
 <CANFp7mVSQEOyT7GrOa4NhAGozt5SMx3yU_ma6tav5bJ8GXJn8w@mail.gmail.com>
To:     Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
X-Mailer: Apple Mail (2.3608.80.23.2.2)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Abhishek,

> This looks good to me.
> 
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>

however it is not enough, we also have to enable address resolution before calling LE Create Connection. It is actually a bit tricky to enable / disable address resolution correctly.

Regards

Marcel