Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200409111829.9508-1-daniels@umanovskis.se>
In-Reply-To: <20200409111829.9508-1-daniels@umanovskis.se>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Thu, 9 Apr 2020 11:10:40 -0400
Message-ID: <CALWDO_Wkd_P5bz7P=UxG=VLQyuikPjbR5SPi7u7DdaB_7x=-ag@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: log advertisement packet length if it gets corrected
To:     daniels@umanovskis.se
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        BlueZ <linux-bluetooth@vger.kernel.org>,
        Daniels Umanovskis <du@axentia.se>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 9, 2020 at 7:28 AM <daniels@umanovskis.se> wrote:
>
> From: Daniels Umanovskis <du@axentia.se>
>
> The error could indicate a problem with the Bluetooth device. It
> is easier to investigate if the packet's actual length gets logged,
> not just the fact that a discrepancy occurred.
>
> Signed-off-by: Daniels Umanovskis <du@axentia.se>
> ---
>  net/bluetooth/hci_event.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 0a591be8b0ae..af7fa7ef94ed 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -5353,7 +5353,8 @@ static void process_adv_report(struct hci_dev *hdev, u8 type, bdaddr_t *bdaddr,
>
>         /* Adjust for actual length */
>         if (len != real_len) {
> -               bt_dev_err_ratelimited(hdev, "advertising data len corrected");
> +               bt_dev_err_ratelimited(hdev, "advertising data len corrected %u -> %u",
> +                                      len, real_len);
>                 len = real_len;
>         }
>
> --
> 2.20.1
>

Reviewed-by: Alain Michaud <alainm@chromium.org>