Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200409103035.96589-1-szymon.janc@codecoup.pl>
In-Reply-To: <20200409103035.96589-1-szymon.janc@codecoup.pl>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 9 Apr 2020 11:29:10 -0700
Message-ID: <CABBYNZKj4kjCBtdads6ntBRs9F9hYiV9o8ACp4Fby3NSmv8M0g@mail.gmail.com>
Subject: Re: [PATCH] test/example-advertisement: Fix advertising when discoverable
To:     Szymon Janc <szymon.janc@codecoup.pl>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Szymon,

On Thu, Apr 9, 2020 at 3:33 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
>
> If adapter is discoverable (or LE-only) advertising was failing due
> to too big adv data being set. Make sure there is enough space left
> for flags if needed.
> ---
>  test/example-advertisement | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/example-advertisement b/test/example-advertisement
> index 88a27ab34..f116893b6 100755
> --- a/test/example-advertisement
> +++ b/test/example-advertisement
> @@ -142,7 +142,7 @@ class TestAdvertisement(Advertisement):
>          Advertisement.__init__(self, bus, index, 'peripheral')
>          self.add_service_uuid('180D')
>          self.add_service_uuid('180F')
> -        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03, 0x04])
> +        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03])
>          self.add_service_data('9999', [0x00, 0x01, 0x02, 0x03, 0x04])
>          self.add_local_name('TestAdvertisement')
>          self.include_tx_power = True
> --
> 2.25.2

Applied, thanks.

-- 
Luiz Augusto von Dentz