Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200321195404.fvyku5hmcuqxt7sg@pali> <20200413162513.2221-1-pali@kernel.org>
 <20200413162513.2221-4-pali@kernel.org>
In-Reply-To: <20200413162513.2221-4-pali@kernel.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 13 Apr 2020 09:51:37 -0700
Message-ID: <CABBYNZLDR-Tztz86qVr3a+Pgtst8XS0uHfP1LwZWopyzwBPXmg@mail.gmail.com>
Subject: Re: [PATCH 3/3] src/profile: Add default SDP record for Headset role
 of HSP 1.2 profile with Erratum 3507
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        David Heidelberg <david@ixit.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

On Mon, Apr 13, 2020 at 9:25 AM Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> This would allow DBus agents to implement HS role of HSP profile.
>

We don't use Signed-off-by on userspace, other than that and the
introduction of have_features Im fine with the patches.

> Signed-off-by: Pali Roh=C3=A1r <pali@kernel.org>
> ---
>  src/profile.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>
> diff --git a/src/profile.c b/src/profile.c
> index 3b7e08f26..09627fbbd 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -56,6 +56,7 @@
>
>  #define DUN_DEFAULT_CHANNEL    1
>  #define SPP_DEFAULT_CHANNEL    3
> +#define HSP_HS_DEFAULT_CHANNEL 6
>  #define HFP_HF_DEFAULT_CHANNEL 7
>  #define OPP_DEFAULT_CHANNEL    9
>  #define FTP_DEFAULT_CHANNEL    10
> @@ -155,6 +156,49 @@
>                 </attribute>                                            \
>         </record>"
>
> +/* SDP record for Headset role of HSP 1.2 profile with Erratum 3507 */
> +#define HSP_HS_RECORD                                                  \
> +       "<?xml version=3D\"1.0\" encoding=3D\"UTF-8\" ?>                 =
   \
> +       <record>                                                        \
> +               <attribute id=3D\"0x0001\">                              =
 \
> +                       <sequence>                                      \
> +                               <uuid value=3D\"0x1108\" />              =
 \
> +                               <uuid value=3D\"0x1131\" />              =
 \
> +                               <uuid value=3D\"0x1203\" />              =
 \
> +                       </sequence>                                     \
> +               </attribute>                                            \
> +               <attribute id=3D\"0x0004\">                              =
 \
> +                       <sequence>                                      \
> +                               <sequence>                              \
> +                                       <uuid value=3D\"0x0100\" />      =
 \
> +                               </sequence>                             \
> +                               <sequence>                              \
> +                                       <uuid value=3D\"0x0003\" />      =
 \
> +                                       <uint8 value=3D\"0x%02x\" />     =
 \
> +                               </sequence>                             \
> +                       </sequence>                                     \
> +               </attribute>                                            \
> +               <attribute id=3D\"0x0005\">                              =
 \
> +                       <sequence>                                      \
> +                               <uuid value=3D\"0x1002\" />              =
 \
> +                       </sequence>                                     \
> +               </attribute>                                            \
> +               <attribute id=3D\"0x0009\">                              =
 \
> +                       <sequence>                                      \
> +                               <sequence>                              \
> +                                       <uuid value=3D\"0x1108\" />      =
 \
> +                                       <uint16 value=3D\"0x%04x\" />    =
 \
> +                               </sequence>                             \
> +                       </sequence>                                     \
> +               </attribute>                                            \
> +               <attribute id=3D\"0x0100\">                              =
 \
> +                       <text value=3D\"%s\" />                          =
 \
> +               </attribute>                                            \
> +               <attribute id=3D\"0x0302\">                              =
 \
> +                       <boolean value=3D\"%s\" />                       =
 \
> +               </attribute>                                            \
> +       </record>"
> +
>  #define HSP_AG_RECORD                                                  \
>         "<?xml version=3D\"1.0\" encoding=3D\"UTF-8\" ?>                 =
   \
>         <record>                                                        \
> @@ -1789,6 +1833,16 @@ static char *get_hfp_ag_record(struct ext_profile =
*ext, struct ext_io *l2cap,
>                                 ext->have_features ? ext->features : 0x9)=
;
>  }
>
> +static char *get_hsp_hs_record(struct ext_profile *ext, struct ext_io *l=
2cap,
> +                                                       struct ext_io *rf=
comm)
> +{
> +       /* HSP 1.2: By default Remote Audio Volume Control is off */
> +       return g_strdup_printf(HSP_HS_RECORD, rfcomm->chan, ext->version,
> +                               ext->name,
> +                               (ext->have_features && (ext->features & 0=
x1))
> +                               ? "true" : "false");
> +}
> +
>  static char *get_hsp_ag_record(struct ext_profile *ext, struct ext_io *l=
2cap,
>                                                         struct ext_io *rf=
comm)
>  {
> @@ -2012,6 +2066,16 @@ static struct default_settings {
>                 .auto_connect   =3D true,
>                 .get_record     =3D get_hfp_ag_record,
>                 .version        =3D 0x0107,
> +       }, {
> +               .uuid           =3D HSP_HS_UUID,
> +               .name           =3D "Headset unit",
> +               .priority       =3D BTD_PROFILE_PRIORITY_HIGH,
> +               .remote_uuid    =3D HSP_AG_UUID,
> +               .channel        =3D HSP_HS_DEFAULT_CHANNEL,
> +               .authorize      =3D true,
> +               .auto_connect   =3D true,
> +               .get_record     =3D get_hsp_hs_record,
> +               .version        =3D 0x0102,
>         }, {
>                 .uuid           =3D HSP_AG_UUID,
>                 .name           =3D "Headset Voice gateway",
> --
> 2.20.1
>


--=20
Luiz Augusto von Dentz