Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4406542ybb; Tue, 14 Apr 2020 06:44:39 -0700 (PDT) X-Google-Smtp-Source: APiQypJfZuePPaelRPt9E7uAJV1sQrvRPVQq5Q6SpdzrTL4ZTVXjsRU9TMG/8fhDltKtCJd1T9YZ X-Received: by 2002:a50:f699:: with SMTP id d25mr20488030edn.244.1586871879651; Tue, 14 Apr 2020 06:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586871879; cv=none; d=google.com; s=arc-20160816; b=uoMLyNInShFthNpojUMQ5uOi/qabJ42243ArGKluqBSFxy4jkHVQUwWUtWqXYxvoL2 9FCPq/TwoXgO0XcgratLJLw33Kz8sX2zJ+Ezc0VGF45wnD5Wv2GLAZ4r9PxAQfU/k/kH dogXZL83oWT2s8ZbIJ909jqG4w6RMfeNfCet5KKbWL39lZFL/rH2yBp5mxAA0wbI3c+h Tv7Ac14OCESTu2HYCGv/qxp/N+J8N4zys7kMLG9myKPsAsHYD1rN5mFRh9XypKpATcPA dyaIO/VmGoqCxZVUzfKO3r84UhDob/cRXIp3Ilt58bCNVVf5UHRv4MMDubhUdvB8nUYv Bmvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=B1nsyhLQuQrAGYoOCtEEWkJmr2vuB/c7EPh8g9SVViQ=; b=fvNKYhIBT/7kPxuD+Gu4humfu9S8H0b4RAZlLUMWZsLD8xpdGEsCM4DtXr8YvSY9Jb dHnyS9aTz9MN68TXSX45GGV0XXIA2tKLYK0LYg1iGvBa26RjtFC/thnBGx3WriohuHoY nPXcO9kGX90YN8jDl9zgKK9FEsyBw3zTAlupI1wiD7e70Oa4paGQ+kmp4CevxUTTfOiD P4ATFF+YLhKXWm5lf7lD+1WeoAiiZzVH8BsJWazMy/j9wNBR//QgxhUCoylAma2ZbR4x GKJDd7RCZg7VCrcJQwdl2GJXVuSla564MHeLDvC/yaXJXBfEyCZqNfNITpXhhLiY72qt 131g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kAECq4dI; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si8295147eja.269.2020.04.14.06.44.15; Tue, 14 Apr 2020 06:44:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kAECq4dI; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390368AbgDNAJ4 (ORCPT + 99 others); Mon, 13 Apr 2020 20:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390364AbgDNAJy (ORCPT ); Mon, 13 Apr 2020 20:09:54 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8C72C0A3BDC for ; Mon, 13 Apr 2020 17:09:54 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id u20so8975978oic.4 for ; Mon, 13 Apr 2020 17:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=B1nsyhLQuQrAGYoOCtEEWkJmr2vuB/c7EPh8g9SVViQ=; b=kAECq4dIFNVbyzp4Saijskoj05OodS2Jxj9qKw762C0wRMlImg6mOuNNPy8QUU99s4 ZOU0PWnHBZrebrZAq3bj4Z3FBAb0q762HJkEfG6TlfRGyfPzQNLFPqPUzqvHyFnO0Ce4 +D5vbHKg/wJA99cT/HCbmGtlo0Iezo3KtLRnD0euVv6jSbkahDjgnS42RYinhprVtXpg cLMkzx/zBqE3bhNNPN6f6Qzs0ixYYn7vg24G+YNeOxIvCsbMof4GbFADxFpNHVJsrso8 D5Tr+S9+HgJlgtPw+Ov5akwqlYbP/JmPUXmWZS75g+vvLeGSEKTa2OXfxAGy2GxXnUJc nsvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=B1nsyhLQuQrAGYoOCtEEWkJmr2vuB/c7EPh8g9SVViQ=; b=GB/mDprkAVbH3Xh/nNrU6eAPaNfzbF/skTJNJH4Mdc1Cs8zQxG9oP73ibq1M5YtMhB 3O5k0pyUlVWo+nX1Pv3REokJYJ4E7SXok/XrirsjQCDL96XtetFjMxfPqaNieomHVdWY spsNOwmMmtSmJxbX5ApV4j9QpoDN/lioDCjFi1huLFw8NuOoFupeC6SdLFM9nmo3YsFn 95VdgLmmy6WyQM5iHkQ4tSO2yRqlOnXIdinou/toChFOwZeSdaK7eUjaGfT8GYbKpqxf M2OC7a0NEQ0ch3OSh1hV3gnnvhL0+m9Ssmtccg6yajUfkK0JX9wwCh9yYmDlL5DQRTiv 7Frg== X-Gm-Message-State: AGi0PuYRl58A+z7rdhdbcnjjsLu+mOyc/h8eUz4GfUrv5KUIlFMNVL5E +IyoZ8wUw5dNHJxXrW1R+YIw5VVQY4rQrW52OmxlwhrN X-Received: by 2002:aca:f584:: with SMTP id t126mr11869219oih.108.1586822993951; Mon, 13 Apr 2020 17:09:53 -0700 (PDT) MIME-Version: 1.0 References: <20200321195404.fvyku5hmcuqxt7sg@pali> <20200413162513.2221-1-pali@kernel.org> In-Reply-To: <20200413162513.2221-1-pali@kernel.org> From: Luiz Augusto von Dentz Date: Mon, 13 Apr 2020 17:09:42 -0700 Message-ID: Subject: Re: [PATCH 0/3] bluez: Export SDP "Remote audio volume control" item for HSP profile To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: "linux-bluetooth@vger.kernel.org" , David Heidelberg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Pali, On Mon, Apr 13, 2020 at 9:25 AM Pali Roh=C3=A1r wrote: > > This patch series fixes handling of zero value in feature list and > provides Remote audio volume control support for HSP profile in both HS > and AG roles. > > Luiz, you wrote that you do not have time to work on this, so I > implemented it myself in this patch series. Could you please find time > at least for reviewing and merging these patches? Thanks. > > Pali Roh=C3=A1r (3): > src/profile: Distinguish between zero-set HFP AG features and unset > HFP AG features > src/profile: Export Remote Audio Volume Control SDP value for HSP HS > role via first bit in features value > src/profile: Add default SDP record for Headset role of HSP 1.2 > profile with Erratum 3507 > > src/profile.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 104 insertions(+), 8 deletions(-) > > -- > 2.20.1 Ive make some changes to remove the need to a flag to detect when the features should be added or not, it is now applied, thanks. --=20 Luiz Augusto von Dentz