Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Apr 2020 10:09:44 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH 0/3] bluez: Export SDP "Remote audio volume control" item
 for HSP profile
Message-ID: <20200414080944.gkh4vfgfh3ruts4q@pali>
References: <20200321195404.fvyku5hmcuqxt7sg@pali>
 <20200413162513.2221-1-pali@kernel.org>
 <CABBYNZLvuDMoFhFSFq50hnjG24DatsHDHNiN2axeC75fSmDRsw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABBYNZLvuDMoFhFSFq50hnjG24DatsHDHNiN2axeC75fSmDRsw@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Monday 13 April 2020 17:09:42 Luiz Augusto von Dentz wrote:
> Hi Pali,
> 
> On Mon, Apr 13, 2020 at 9:25 AM Pali Rohár <pali@kernel.org> wrote:
> >
> > This patch series fixes handling of zero value in feature list and
> > provides Remote audio volume control support for HSP profile in both HS
> > and AG roles.
> >
> > Luiz, you wrote that you do not have time to work on this, so I
> > implemented it myself in this patch series. Could you please find time
> > at least for reviewing and merging these patches? Thanks.
> >
> > Pali Rohár (3):
> >   src/profile: Distinguish between zero-set HFP AG features and unset
> >     HFP AG features
> >   src/profile: Export Remote Audio Volume Control SDP value for HSP HS
> >     role via first bit in features value
> >   src/profile: Add default SDP record for Headset role of HSP 1.2
> >     profile with Erratum 3507
> >
> >  src/profile.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 104 insertions(+), 8 deletions(-)
> >
> > --
> > 2.20.1
> 
> Ive make some changes to remove the need to a flag to detect when the
> features should be added or not, it is now applied, thanks.

Ok, thank you!

In commit you did one mistake:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=040bd56a948f4d1ecd6987cdf0ba51779dc0c02a

+		/* HSP AG role does not provide any features */
+		return 0;

It should return -ENODATA as AG role does not provide any features, so
has_features needs to be set to false.