Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200321195404.fvyku5hmcuqxt7sg@pali> <20200413162513.2221-1-pali@kernel.org>
 <CABBYNZLvuDMoFhFSFq50hnjG24DatsHDHNiN2axeC75fSmDRsw@mail.gmail.com> <20200414195334.cucssmdt3xj7lf2y@pali>
In-Reply-To: <20200414195334.cucssmdt3xj7lf2y@pali>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 14 Apr 2020 13:28:19 -0700
Message-ID: <CABBYNZ+BD2g35wWHocp25kK_s07y7Yec8+51pEv37bh3U-fR-Q@mail.gmail.com>
Subject: Re: [PATCH 0/3] bluez: Export SDP "Remote audio volume control" item
 for HSP profile
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        David Heidelberg <david@ixit.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

Can you send a proper patch adding these, have you changed the code
already to use channel 7?

On Tue, Apr 14, 2020 at 12:53 PM Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> Hello Luiz!
>
> I have there another simple change for updating documentation:
>
> diff --git a/doc/profile-api.txt b/doc/profile-api.txt
> index ec18034a6..183c6c11a 100644
> --- a/doc/profile-api.txt
> +++ b/doc/profile-api.txt
> @@ -16,10 +16,33 @@ Object path /org/bluez
>                         If an application disconnects from the bus all
>                         its registered profiles will be removed.
>
> +                       Some predefined services:
> +
> +                       HFP AG UUID: 0000111f-0000-1000-8000-00805f9b34fb
> +
> +                               Default profile Version is 1.7, profile F=
eatures
> +                               is 0b001001 and RFCOMM channel is 13.
> +                               Authentication is required.
> +
>                         HFP HS UUID: 0000111e-0000-1000-8000-00805f9b34fb
>
> -                               Default RFCOMM channel is 6. And this req=
uires
> -                               authentication.
> +                               Default profile Version is 1.7, profile F=
eatures
> +                               is 0b000000 and RFCOMM channel is 7.
> +                               Authentication is required.
> +
> +                       HSP AG UUID: 00001112-0000-1000-8000-00805f9b34fb
> +
> +                               Default profile Version is 1.2, RFCOMM ch=
annel
> +                               is 12 and Authentication is required. Doe=
s not
> +                               support any Features, option is ignored.
> +
> +                       HSP HS UUID: 00001108-0000-1000-8000-00805f9b34fb
> +
> +                               Default profile Version is 1.2, profile F=
eatures
> +                               is 0b0 and RFCOMM channel is 6. Authentic=
ation
> +                               is required. Features is one bit value, s=
pecify
> +                               capability of Remote Audio Volume Control
> +                               (by default turned off).
>
>                         Available options:
>
>
>
> There is a mistake in documentation that default rfcomm channel for HFP
> HS profile is 6. But in reality default rfcomm channel for HFP is 7.
> Channel 6 is default for HSP HS profile as can be seen in src/profile.c.


--=20
Luiz Augusto von Dentz