Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3687497ybz; Mon, 20 Apr 2020 07:40:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKZlGkX9SptWqqOswLoiMXyRJKEckJbOMSCDLf8Adzg0y9H0lQ4Tli+nCxAS+pi97/FuTKW X-Received: by 2002:a05:6402:75a:: with SMTP id p26mr7420375edy.311.1587393654337; Mon, 20 Apr 2020 07:40:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587393654; cv=none; d=google.com; s=arc-20160816; b=fASq2xJ+De19mBe/zgpY022i0B73OU3H/WYgglBVlPLky4PyhqcBPYnSRhtjOLzc2N N3Myh/rX5YKvwmzkbp7K4XAcJklpv15JiRVBy4o7Ugxa/vjrB9uHjpqtm+lIN5CNuaIr xkNHm8iIuynKMOb/jidpneTynsJv/g3OXSYmLC/ilXWSJzGVUjriz9RlRJo81P+dWdAP /eWZVhpD8d7V1WWpxykPql/D9fC2AKzHUsXaG+6aAittp75BbD9qYazvPdNbpMQ5xno5 oi/J9VtHbZqFbPJCuWixdbe71Pw1a+t/LKLWbik5pTllmWE5JmzOP/yq+/dViz3Bzjn7 pNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=G+YdSqbZIOXv7Pt91zzsNWjw+6293WnDt6/zF2H+4J8=; b=oQrMMfY+mrZCHcEUqoYejPwc0j0ILMKio1Gd6dYxocU85eQo2BUs5Z00ZmaJDtT5rz HChSECLZDGTC6nxKFxJy/PR9ysP74g/jDZYbJd/j6tvSlmYxokWrL2VYeTyz8cBN7dK9 Fz7NbJaQVRZ73ArUxEei9L+5+s6/2H1j8BLDNsNPOt1wXwkFoexaQ64FEgcwIQFrx5bf qjeVrdLbVCC3PxUAMljiujfKElJ+Ql5VtEEg3uYaGGSW7K4Vq+1S0OtADkpTJ4FK3IDs BMoaXGBtHZEOj8BQzxXRjlmfkJc0dYuIUEAFlvGTJLCpAx93egq7JkZ7leh7kH6zIP0v Cdjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq19si645400edb.333.2020.04.20.07.40.12; Mon, 20 Apr 2020 07:40:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgDTNPS (ORCPT + 99 others); Mon, 20 Apr 2020 09:15:18 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49480 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgDTNPS (ORCPT ); Mon, 20 Apr 2020 09:15:18 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: scerveau) with ESMTPSA id BA8F32A0DCD From: =?UTF-8?q?St=C3=A9phane=20Cerveau?= To: linux-bluetooth@vger.kernel.org Cc: =?UTF-8?q?St=C3=A9phane=20Cerveau?= Subject: [PATCH 0/1] add hog ref in hog_attach_instance Date: Mon, 20 Apr 2020 15:14:47 +0200 Message-Id: <20200420131448.21796-1-scerveau@collabora.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org When I tried to connect a bluetooth gamepad 8718, I was experiencing a crash which can be reproduced always. https://www.amazon.com/Controller-PowerLead-Wireless-Compatible-Android/dp/B07XJ37HPK After investigation, it appears that instance was not reffed initially when added to the slist and double free was requested on this hog during the free of the slist (unref during a destroy_gatt_req). Stéphane Cerveau (1): add hog ref in hog_attach_instance profiles/input/hog-lib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1