Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200420120705.89691-1-szymon.janc@codecoup.pl> <d73bac9fdec3a002478cc1a15da1385e1cd6ce12.camel@intel.com>
In-Reply-To: <d73bac9fdec3a002478cc1a15da1385e1cd6ce12.camel@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 20 Apr 2020 11:00:51 -0700
Message-ID: <CABBYNZKV3_1DWHEUUB0pXzeeVQdOJq7qrf_nV5=KPp8DCWkE+w@mail.gmail.com>
Subject: Re: [PATCH 1/4] android: Fix build with GCC 10
To:     "Gix, Brian" <brian.gix@intel.com>
Cc:     "szymon.janc@codecoup.pl" <szymon.janc@codecoup.pl>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Szymon,

On Mon, Apr 20, 2020 at 9:42 AM Gix, Brian <brian.gix@intel.com> wrote:
>
> Hi Luiz,
>
> Modulo my question about nul termination on patch 3/4,  This patchset resolves all of the GCC 10 build
> error/warnings and, I think, should be applied.
>
> On Mon, 2020-04-20 at 14:07 +0200, Szymon Janc wrote:
> > status and state are used to hold various enum types depending on test
> > and callback passed. Define them as int to avoid warnings about enum
> > assignment from invalid type.
> > ---
> >  android/tester-main.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/android/tester-main.h b/android/tester-main.h
> > index 8a7384c57..6bdfdbcdb 100644
> > --- a/android/tester-main.h
> > +++ b/android/tester-main.h
> > @@ -653,8 +653,8 @@ struct map_inst_data {
> >   * matching with expected step data.
> >   */
> >  struct bt_callback_data {
> > -     bt_state_t state;
> > -     bt_status_t status;
> > +     int state;
> > +     int status;
> >       int num_properties;
> >       bt_property_t *properties;
> >       bt_uuid_t *uuid;

Applied, thanks.

-- 
Luiz Augusto von Dentz