Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [BlueZ PATCH v2] doc:Adding LESupportedRoles property
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200421204722.195637-1-alainm@chromium.org>
Date:   Wed, 22 Apr 2020 19:34:50 +0200
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <37A7A874-31C4-4DD7-AB71-1C3C0837DDAE@holtmann.org>
References: <20200421204722.195637-1-alainm@chromium.org>
To:     Alain Michaud <alainm@chromium.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Alain,

> This change adds a new property to indicate the support for concurrent
> LE roles which means that the controller has reported the appropriate
> LE_Supported_States (hdev->le_states) and that the controller's driver
> has reported correctly handling the various reported states.
> ---
> 
> doc/adapter-api.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index acae032d9..f76e1e910 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -326,3 +326,11 @@ Properties	string Address [readonly]
> 
> 			Local Device ID information in modalias format
> 			used by the kernel and udev.
> +
> +		array{string} LERoles [readonly]

I would just call it Roles. Then we can extend it without having to be LE specific.

> +
> +			List of supported LE roles.  Possible values:
> +				"central" - Supports the central role.
> +				"peripheral" - Supports the peripheral role.
> +				"central-peripheral" - Supports both roles
> +						       concurrently.

Otherwise I am good with this.

Regards

Marcel