Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200423233414.15141-1-pali@kernel.org>
In-Reply-To: <20200423233414.15141-1-pali@kernel.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 24 Apr 2020 10:24:58 -0700
Message-ID: <CABBYNZJGz0wrGohqXmjgNF_8gx7a2E61kQB8QzGDyCWOvm4dgQ@mail.gmail.com>
Subject: Re: [PATCH] btio: Fix error number
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

On Thu, Apr 23, 2020 at 4:36 PM Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> In commit d20ee8273e61e16c78582344f274254973cdf00f was unintentionally
> negated error number. Fix this mistake.
> ---
>  btio/btio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/btio/btio.c b/btio/btio.c
> index 460aaf5be..13c731062 100644
> --- a/btio/btio.c
> +++ b/btio/btio.c
> @@ -230,7 +230,7 @@ static gboolean connect_cb(GIOChannel *io, GIOConditi=
on cond,
>
>         if (err < 0) {
>                 ba2str(&conn->dst, addr);
> -               g_set_error(&gerr, BT_IO_ERROR, err,
> +               g_set_error(&gerr, BT_IO_ERROR, -err,
>                         "connect to %s: %s (%d)", addr, strerror(-err), -=
err);
>         }
>
> @@ -1718,7 +1718,7 @@ GIOChannel *bt_io_connect(BtIOConnect connect, gpoi=
nter user_data,
>
>         if (err < 0) {
>                 ba2str(&opts.dst, addr);
> -               g_set_error(gerr, BT_IO_ERROR, err,
> +               g_set_error(gerr, BT_IO_ERROR, -err,
>                                 "connect to %s: %s (%d)", addr, strerror(=
-err),
>                                 -err);
>                 g_io_channel_unref(io);
> --
> 2.20.1

Applied, thanks.

--=20
Luiz Augusto von Dentz