Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200423142305.66778-1-alainm@chromium.org> <5347568.DvuYhMxLoT@ix>
 <CALWDO_Vk-JCtViCWSoCZRxhGtKKhFkJZTJKctOw7NBRJwT_zdg@mail.gmail.com>
In-Reply-To: <CALWDO_Vk-JCtViCWSoCZRxhGtKKhFkJZTJKctOw7NBRJwT_zdg@mail.gmail.com>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Mon, 27 Apr 2020 10:57:52 -0400
Message-ID: <CALWDO_XsouHaxheRgR7HGkLxf4U1ag0pxCnVN6zLLqbZF=rjVg@mail.gmail.com>
Subject: Re: [BlueZ PATCH v3] doc:Adding Roles property
To:     Szymon Janc <szymon.janc@codecoup.pl>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>,
        Alain Michaud <alainm@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Any more feedback on this Api design?

On Thu, Apr 23, 2020 at 10:51 AM Alain Michaud <alainmichaud@google.com> wrote:
>
> On Thu, Apr 23, 2020 at 10:42 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
> >
> > Hi,
> >
> > On Thursday, 23 April 2020 16:23:05 CEST Alain Michaud wrote:
> > > This change adds a new property to indicate the support for concurrent
> > > roles which means that the controller has reported the appropriate
> > > LE_Supported_States (hdev->le_states) and that the controller's driver
> > > has reported correctly handling the various reported states.
> > > ---
> > >
> > >  doc/adapter-api.txt | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > > index acae032d9..1a7255750 100644
> > > --- a/doc/adapter-api.txt
> > > +++ b/doc/adapter-api.txt
> > > @@ -326,3 +326,11 @@ Properties       string Address [readonly]
> > >
> > >                       Local Device ID information in modalias format
> > >                       used by the kernel and udev.
> > > +
> > > +             array{string} Roles [readonly]
> > > +
> > > +                     List of supported roles. Possible values:
> > > +                             "central": Supports the central role.
> > > +                             "peripheral": Supports the peripheral
> > role.
> > > +                             "central-peripheral": Supports both
> > roles
> > > +
> > concurrently.
> >
> > If this is an array os strings why central-peripheral is needed?
> The keyword in the description is "concurrently".  Not all adapters
> support being peripheral and central concurrently.
>
> >
> >
> > --
> > pozdrawiam
> > Szymon Janc
> >
> >