Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200421155828.Bluez.v1.1.I6e4fbf41b1815dc3d497da5d9c94b18e9c912cba@changeid>
In-Reply-To: <20200421155828.Bluez.v1.1.I6e4fbf41b1815dc3d497da5d9c94b18e9c912cba@changeid>
From:   Archie Pusaka <apusaka@google.com>
Date:   Tue, 28 Apr 2020 12:30:51 +0800
Message-ID: <CAJQfnxFxJwgAj+JWFFCG+b=zDRSX04a1e0mA2cB1fCpsJmoMug@mail.gmail.com>
Subject: Re: [Bluez PATCH v1] gatt: Fix service_changed characteristic permission
To:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi BlueZ maintainers,

Please kindly take a look at this patch, thank you!

On Tue, 21 Apr 2020 at 15:59, Archie Pusaka <apusaka@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> According to bluetooth spec Ver 5.2, Vol 3, Part G, 7.1, the
> service_changed characteristic is not readable. Therefore, this
> patch marks it as such.
> ---
>
>  src/gatt-database.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gatt-database.c b/src/gatt-database.c
> index f2da27694..8cbe09bae 100644
> --- a/src/gatt-database.c
> +++ b/src/gatt-database.c
> @@ -1197,7 +1197,7 @@ static void populate_gatt_service(struct btd_gatt_database *database)
>
>         bt_uuid16_create(&uuid, GATT_CHARAC_SERVICE_CHANGED);
>         database->svc_chngd = gatt_db_service_add_characteristic(service, &uuid,
> -                               BT_ATT_PERM_READ, BT_GATT_CHRC_PROP_INDICATE,
> +                               BT_ATT_PERM_NONE, BT_GATT_CHRC_PROP_INDICATE,
>                                 NULL, NULL, database);
>
>         database->svc_chngd_ccc = service_add_ccc(service, database, NULL, NULL,
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>