Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH] Bluetooth: btbcm: Do not free IRQ on close if we did not
 request it
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200427145414.121700-1-hdegoede@redhat.com>
Date:   Tue, 28 Apr 2020 11:39:39 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <F764A836-9722-4192-AEB8-551DE080F175@holtmann.org>
References: <20200427145414.121700-1-hdegoede@redhat.com>
To:     Hans de Goede <hdegoede@redhat.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Hans,

> When the patch-ram is missing the hci_bcm code does not request the
> IRQ, in this case we should not try to free it from bcm_close()
> 
> This fixes the following WARN statements + backtraces:
> [  332.670662] WARNING: CPU: 3 PID: 4743 at kernel/irq/devres.c:143 devm_free_irq+0x45/0x50
> [  332.670882] Trying to free already-free IRQ 44
> [  332.670891] WARNING: CPU: 3 PID: 4743 at kernel/irq/manage.c:1718 free_irq+0x1f4/0x390
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/bluetooth/hci_bcm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

the patch doesn’t apply cleanly against bluetooth-next tree. Can you send a revised one. Thanks.

Regards

Marcel