Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp869711ybz; Fri, 1 May 2020 10:01:52 -0700 (PDT) X-Google-Smtp-Source: APiQypI2XdmYHn06sinq9zgmItisphYNtYAABFn+4p7tM3fyeIETKlQe62I0Yg1mWmgHU7hORQP+ X-Received: by 2002:a17:906:adb:: with SMTP id z27mr4099983ejf.263.1588352511931; Fri, 01 May 2020 10:01:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588352511; cv=none; d=google.com; s=arc-20160816; b=fp3Pj6qmAlxkcI3FOO79rJ2Oa7s1EE9njzSOXfIm76960kLLB+Kl+Jq8PNXXoBtB/E 3ffPUk4oPxC/yfWUcJCGqxYy31XvcKwKBY3r9B5TeJqAojOTafEyygzV7xzI3AcZHdE2 2o9Kw33MQsDrjCoBtrz6ybkIsWMC1xWXKpKfQb6BD4ZhVrFwLCs6VXm3aRFNkR4/BBy2 wEZfsIf5/5fcsiW5Ov4nlLzWE18KOtlOZjKvXN8tp5EAb4i/XKgKIK2o2ptzPcpDM5S1 VxnfgEOlug/VGldditmQl06ozr0GrE0YZmWgebou/8GZQP6TdbT4XEZB7DdJmgxr4jrz qKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=DtZO9WRA6CSwL6gM5awASXGtL9BINiQLBZ4YY8nEKQ0=; b=NdClsmcfIsh/404G2njXIaMHrBucmpeiq2xmauTtGkLErpRaeQvxYHDtRvdTuF1Uda CmzIBd2pfUNg9rKV859QHWEjKHiHr03GrqaGvnymkzomNE2v8L2DS7eO3Xz+/oZxM19J DAS2b7yYnz94o3oMfs4PQBygGd79LOVNPb34gsg3VQvZOUqT6qdS2ZwMhx45eyx4pMig wGPNxlPdPMcjT/DZ5GzmvGozfMuJII5jhN6PfjiQ9nhT/dfnftFJPsinxnKvGFLCiDX0 11ax1Z94ajgu+nqnPX+IoVXy3NH/ki96QcH+2NOYkcVx5XE0YVXrfTvOXcj1m8zMh63X SW1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id da15si2100317edb.140.2020.05.01.10.01.11; Fri, 01 May 2020 10:01:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729279AbgEARBC (ORCPT + 99 others); Fri, 1 May 2020 13:01:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:21285 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728841AbgEARBC (ORCPT ); Fri, 1 May 2020 13:01:02 -0400 IronPort-SDR: ugJjwQfUieEnP2olAmLfQahnS2AH6enYG4ZYFRcK2QkeOst28Bu7OuL5UKkCBK7JVG6IH73NKa 3OvjGK2diynw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 10:01:01 -0700 IronPort-SDR: Rpnah1ajWODl7WbCWdCpr0EjaBbh1/fjfYKTEMAdbNcoBSTTW7yu2qOcW2Dtcgo4Hz1yMPKijy NUgROfFOIdTw== X-IronPort-AV: E=Sophos;i="5.73,340,1583222400"; d="scan'208";a="433367572" Received: from han1-mobl3.jf.intel.com ([10.254.74.98]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 10:01:01 -0700 From: Tedd Ho-Jeong An To: linux-bluetooth@vger.kernel.org Cc: Tedd Ho-Jeong An Subject: [PATCH v2] Bluetooth: Fix advertising handle is set to 0 Date: Fri, 1 May 2020 10:00:50 -0700 Message-Id: <20200501170050.42758-1-tedd.an@linux.intel.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Tedd Ho-Jeong An This patch fix the advertising handle is set to 0 regardless of actual instance value. The affected commands are LE Set Advertising Set Random Address, LE Set Extended Advertising Data, and LE Set Extended Scan Response Data commands. Signed-off-by: Tedd Ho-Jeong An --- net/bluetooth/hci_request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index 9ea40106ef17..3f470f0e432c 100644 --- a/net/bluetooth/hci_request.c +++ b/net/bluetooth/hci_request.c @@ -1447,7 +1447,7 @@ void __hci_req_update_scan_rsp_data(struct hci_request *req, u8 instance) memcpy(hdev->scan_rsp_data, cp.data, sizeof(cp.data)); hdev->scan_rsp_data_len = len; - cp.handle = 0; + cp.handle = instance; cp.length = len; cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; @@ -1591,7 +1591,7 @@ void __hci_req_update_adv_data(struct hci_request *req, u8 instance) hdev->adv_data_len = len; cp.length = len; - cp.handle = 0; + cp.handle = instance; cp.operation = LE_SET_ADV_DATA_OP_COMPLETE; cp.frag_pref = LE_SET_ADV_DATA_NO_FRAG; @@ -1876,7 +1876,7 @@ int __hci_req_setup_ext_adv_instance(struct hci_request *req, u8 instance) memset(&cp, 0, sizeof(cp)); - cp.handle = 0; + cp.handle = instance; bacpy(&cp.bdaddr, &random_addr); hci_req_add(req, -- 2.25.4