Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "CEE Forostyan, Konstantin" <Konstantin.Forostyan@peiker-cee.de>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: AW: [PATCH] Bluetooth: L2CAP: Fix errors during
 L2CAP_CREDIT_BASED_CONNECTION_REQ (0x17)
Thread-Topic: [PATCH] Bluetooth: L2CAP: Fix errors during
 L2CAP_CREDIT_BASED_CONNECTION_REQ (0x17)
Thread-Index: AQHWHkYRSCKhloHlV0Kvhytr6OLHO6iQNiiAgAfn+/o=
Date:   Mon, 4 May 2020 16:12:01 +0000
Message-ID: <4233257d2fb24d0293c221d4bab65a2d@peiker-cee.de>
References: <77b02337bc404dea9fa88a286c091b83@peiker-cee.de>
 <08f0a119cfa0481fbf49d7fde47a08fc@bshg.com>
 <cc33f16c2e164328b8248fc3967ebed5@peiker-cee.de>
 <2723effa610a46a8a9343be31bcffc71@peiker-cee.de>,<CABBYNZ+eXJJSoQ7CGj9canfQ1eHDMzEKcY6o9GBKzAaErQs6LQ@mail.gmail.com>
In-Reply-To: <CABBYNZ+eXJJSoQ7CGj9canfQ1eHDMzEKcY6o9GBKzAaErQs6LQ@mail.gmail.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Luiz,

Sorry for delay with the answer, I had a day off last Friday.

> so please send them as proper patches
I did this in a sepatare email, hopefully it is correct. This is my first time submitting a kernel patch.

> please ensure l2cap-tester is working.
Unfortunately I didn't find a way to even integrate l2cap-tester into our embedded platform, so I couldn't make any tests with it. Is it a separate tool or something that is integrated into test-runner tool? If yes, the test-runner requires qemu that we don't have.

Best regards,
Konstantin


Von: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Gesendet: Mittwoch, 29. April 2020 19:17
An: CEE Forostyan, Konstantin
Cc: linux-bluetooth@vger.kernel.org
Betreff: Re: [PATCH] Bluetooth: L2CAP: Fix errors during L2CAP_CREDIT_BASED_CONNECTION_REQ (0x17)
?   
Hi Konstantin,

On Wed, Apr 29, 2020 at 9:52 AM CEE Forostyan, Konstantin
<Konstantin.Forostyan@peiker-cee.de> wrote:
>
> Hi All,
>
> During Bluetooth qualification tests I found out that Bluetooth stack responds with an error to a correct L2CAP_CREDIT_BASED_CONNECTION_REQ. Please review the 2 bugfixes I made in kernel in order to correct this problem.
>
> Best regards
> Konstantin
>
>
> --- a/net/bluetooth/l2cap_core.c??????? 2020-04-28 18:19:10.481887583 +0200
> +++ b/net/bluetooth/l2cap_core.c??????? 2020-04-28 18:21:41.000000000 +0200
> @@ -5817,7 +5817,7 @@
>???????? if (!enable_ecred)
>???????????????? return -EINVAL;
>
> -?????? if (cmd_len < sizeof(*req) || cmd_len - sizeof(*req) % sizeof(u16)) {
> +?????? if (cmd_len < sizeof(*req) || (cmd_len - sizeof(*req)) % sizeof(u16)) {
>???????????????? result = L2CAP_CR_LE_INVALID_PARAMS;
>???????????????? goto response;
>???????? }
> @@ -5855,7 +5855,7 @@
>???????? }
>
>???????? result = L2CAP_CR_LE_SUCCESS;
> -?????? cmd_len -= sizeof(req);
> +?????? cmd_len -= sizeof(*req);
>???????? num_scid = cmd_len / sizeof(u16);
>
>???????? for (i = 0; i < num_scid; i++) {

Weird that I didn't run into this when creating the test for
l2cap-tester, they look correct though so please send them as proper
patches so we can apply to bluetooth-next, also please ensure
l2cap-tester is working.

-- 
Luiz Augusto von Dentz