Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200407205217.1002534-1-marcel@holtmann.org> <CANFp7mVSQEOyT7GrOa4NhAGozt5SMx3yU_ma6tav5bJ8GXJn8w@mail.gmail.com>
 <1FE78D4A-E6EC-440C-B76E-82F75D615D92@holtmann.org>
In-Reply-To: <1FE78D4A-E6EC-440C-B76E-82F75D615D92@holtmann.org>
From:   Sathish Narasimman <nsathish41@gmail.com>
Date:   Tue, 5 May 2020 19:14:21 +0530
Message-ID: <CAOVXEJ+rAJMbdqAU7mvpPbVjnZyPzMO0LhUOC6ZXOJbaZKn=rg@mail.gmail.com>
Subject: Re: [PATCH v3] Bluetooth: Configure controller address resolution if available
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel

On Wed, Apr 8, 2020 at 11:46 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Abhishek,
>
> > This looks good to me.
> >
> > Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> however it is not enough, we also have to enable address resolution before calling LE Create Connection. It is actually a bit tricky to enable / disable address resolution correctly.
When we receive directed_adv we disable the scan. which disables
address_resolution.
immediately I was trying to enable address resolution inside
hci_req_add_le_create_conn
@@ -813,6 +813,12 @@ static void hci_req_add_le_create_conn(struct
hci_request *req,
                        return;
        }

+       if (use_ll_privacy(hdev) &&
+           !hci_dev_test_flag(hdev, HCI_LL_RPA_RESOLUTION)) {
+               __u8 enable = 0x01;
+               hci_req_add(req, HCI_OP_LE_SET_ADDR_RESOLV_ENABLE, 1, &enable);
+       }
+
        if (use_ext_conn(hdev)) {
                struct hci_cp_le_ext_create_conn *cp;
                struct hci_cp_le_ext_conn_param *p;
where this fails as the flag is not cleared yet.
where the idea is to bool addr_resolv as below
->hci_req_add_le_scan_disable(req, addr_resolv)
In which we can stop disabling addr_resolution and continue
le_create_conn during hci_connect_le
>
> Regards
>
> Marcel
>

Regards
Sathish N