Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200501215352.23858-1-sonnysasaka@chromium.org> <4A9E7F0B-4AB8-4330-BB2B-1A0EAA4EFDE8@holtmann.org>
In-Reply-To: <4A9E7F0B-4AB8-4330-BB2B-1A0EAA4EFDE8@holtmann.org>
From:   Alain Michaud <alainmichaud@google.com>
Date:   Wed, 6 May 2020 10:01:36 -0400
Message-ID: <CALWDO_WGrReJ2rRyrh6J0WpTOjDoP-cHdhzQwe5UJx3GqjUimg@mail.gmail.com>
Subject: Re: [PATCH] build: Add option to disable battery profile
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Sonny Sasaka <sonnysasaka@chromium.org>,
        BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

On Wed, May 6, 2020 at 7:24 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > Some clients may want to handle battery profile through the generic GAT=
T
> > interface rather than BlueZ's internal Battery interface.
> > ---
> > Makefile.plugins | 2 ++
> > configure.ac     | 4 ++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Makefile.plugins b/Makefile.plugins
> > index 98eee9ec8..b9733d31c 100644
> > --- a/Makefile.plugins
> > +++ b/Makefile.plugins
> > @@ -101,8 +101,10 @@ builtin_cppflags +=3D $(ALSA_CFLAGS)
> > builtin_ldadd +=3D $(ALSA_LIBS)
> > endif
> >
> > +if BATTERY
> > builtin_modules +=3D battery
> > builtin_sources +=3D profiles/battery/battery.c
> > +endif
> >
> > if SIXAXIS
> > plugin_LTLIBRARIES +=3D plugins/sixaxis.la
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..d4fa862b5 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -181,6 +181,10 @@ AC_ARG_ENABLE(hog, AC_HELP_STRING([--disable-hog],
> >               [disable HoG profile]), [enable_hog=3D${enableval}])
> > AM_CONDITIONAL(HOG, test "${enable_hog}" !=3D "no")
> >
> > +AC_ARG_ENABLE(battery, AC_HELP_STRING([--disable-battery],
> > +             [disable battery profile]), [enable_battery=3D${enableval=
}])
> > +AM_CONDITIONAL(BATTERY, test "${enable_battery}" !=3D "no")
> > +
> > AC_ARG_ENABLE(health, AC_HELP_STRING([--enable-health],
> >               [enable health profiles]), [enable_health=3D${enableval}]=
)
> > AM_CONDITIONAL(HEALTH, test "${enable_health}" =3D "yes")
>
> I have a little bit concern splitting this since battery service and HoG =
are kinda connected. Wouldn=E2=80=99t it be better we have a cleaner interf=
ace. Maybe we should actually integrate cleanly with /dev/upower or similar=
.
I agree, we are re-evaluating this.

>
> Regards
>
> Marcel
>