Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp2052578ybj; Wed, 6 May 2020 09:45:29 -0700 (PDT) X-Google-Smtp-Source: APiQypKo2Nh3w4Rz2n7bT2Dug1rXFMTgVJiSbIr+DWrwp2fkRdFrN+1sJW5vzXRNAdoj/0PSFMN1 X-Received: by 2002:a05:6402:1ad0:: with SMTP id ba16mr8023618edb.11.1588783529074; Wed, 06 May 2020 09:45:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588783529; cv=none; d=google.com; s=arc-20160816; b=Ljy8jwLgxd50ciIMTWQPyby6ljl1QkLGYwgjhxkw42BPFs5Ezswo5evypRTYS3UfAD s0M+L2bAO9w0EHsIoinVBJwZ6u2aaunbzpVjBTD/TSlaLPZhwsz3+8ogar3cLPcacjGR /vncltJQoEr2ct/GgD/rWROpTxTU2+GVqT9dEwfn29gWEmCuhH84WlsxsY9FEh3CRkuh NLYnwgfkdDoKDVccjxaTk3yyJhSBbVLYh3s27fGIDRujKgZSCy1dv9ieJ4mQ4yJ3lV4L LnEQo3q5iKMgNNuDzr6ch4YXes8BbALNGmPzBjrKXpHL2ol8iszsStnjALUZyo5pi6r9 badw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=h4afMjEs+JpKLCUsRU/4wvkdd+2L0OnimyUcHBghkxE=; b=ZLxSBWXt2LQL+eFqph0P5lWNJAelNlru6JEjVNBttDJPaZZ8Y0Y0pLb/ZVzz+ns14D 0XtHAeAlfZwvZCRtQ5rkITj/G6bTO7qTrStxox7GGycqxrl3/owDhbclRqFeScr5qu69 iM9byS6pyHVi3gXkcGtArga6RNjEHzAhX3H2qLeelaozgXJuHT7cojKiU/IHwuCwoCOX sRBpFIo9VAIMdjV2yh976rbODBwX8XxLrakcIUubj9xtVuO5dPQKBKPQTTbk1V/tt8Z/ 7eUX/2KkeP1tADCDvpmqJajZHnstT8kgIrDabzRND2tmDE6jepOfOOXY837+BJrGVura 4Xfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si1408624edx.13.2020.05.06.09.45.01; Wed, 06 May 2020 09:45:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730264AbgEFQod convert rfc822-to-8bit (ORCPT + 99 others); Wed, 6 May 2020 12:44:33 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:56848 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730237AbgEFQod (ORCPT ); Wed, 6 May 2020 12:44:33 -0400 Received: from marcel-macpro.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 146FACED08; Wed, 6 May 2020 18:54:13 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] build: Add option to disable battery profile From: Marcel Holtmann In-Reply-To: Date: Wed, 6 May 2020 18:44:31 +0200 Cc: Bastien Nocera , Sonny Sasaka , "linux-bluetooth@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: References: <20200501215352.23858-1-sonnysasaka@chromium.org> <4A9E7F0B-4AB8-4330-BB2B-1A0EAA4EFDE8@holtmann.org> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, >>> I have a little bit concern splitting this since battery service and >>> HoG are kinda connected. Wouldn’t it be better we have a cleaner >>> interface. Maybe we should actually integrate cleanly with >>> /dev/upower or similar. >> >> Wat? > > I guess Marcel was refering to something like uhid though Im not sure > that exists, or does it? That said one alternative would make uhid > integrate the battery status, but I guess devices can also expose this > over hid directly so I wonder if we can translate the Battery Service > status to hid power strength that way we don't need any communication > over D-Bus. I thought we had created a /dev/upower to create battery information. Maybe it was just /dev/uleds and the other one was left up in the air. Regards Marcel