Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp2055625ybj; Wed, 6 May 2020 09:48:51 -0700 (PDT) X-Google-Smtp-Source: APiQypL1WM+3x22pTtY5i0bxqpmIZcFlhk5SxTYrqNrFT9yKfVQRPUasAZuzl3ngy1dCnRGmRAdK X-Received: by 2002:a50:8b42:: with SMTP id l60mr2145091edl.55.1588783731565; Wed, 06 May 2020 09:48:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588783731; cv=none; d=google.com; s=arc-20160816; b=X1/Wrig2s3+hvCUO2fp6D9wOZ0tfLFAtqQv3h1bn2KW5+JWxnmh+mG92bzdFRQZC0B zM0ehr+XnpneAK45dCbJKJKFNdN+KU9I6VfAZ8gjYgtE3li2HaaKsTEHu3EjDHATeaOs E9qPvfyfjLMp3/2NcjgHo8WGxYYQFsF4QUV2nehYh2mb+EGdz+DR99HTjzbPQj0MViJo BiFgilN3ZiRS3hzDlf5xcCo4jT6DTil9W/eoxdONYHk7ag0z6DGXrpUvNtU1frtQd3DI 4bQg47xB7XsLGkSEdsc48HDRvJgYzSZuOJoZal9Z/NvMNqhecFa+88nSuJHU25dufpIQ 5GJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=l5ABB6HXdl4YnzQdkjQ1bvC7//77Zg5tnh+Hhr5dEHk=; b=0iwISvBXU4MBLTkaCpBHBFr85OPDSimwTz3NZcErcrkVhanhz3DKW/4h9J3csr0f9t 4v8/TNCF2l/2ltDnzIBkssVHzZ3xC6qdeGIA0tmsgG0JKiOMTRd0gG17PjtpfBkoBJ5o d82zuuwOmETQGsIqyDeYIAFfu0qO984yHXB5en+7Lbtcwvu52X0EUxIwi6pjLBP2zTye 2OYP6dr3Iuo27FLeZ189j/YtqyhWgV2SIzgUcDcWyTJvWgJO6kqsnstLu/n/1Ehv6JSL mrhOaXnVppqKTNUxSyqhwID1nOmoOPNkIT2Z0SymbqOF5n28XLrrUofto92LoxANBhgs TgHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TJn9RFT5; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si1479743edl.558.2020.05.06.09.48.27; Wed, 06 May 2020 09:48:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TJn9RFT5; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729936AbgEFQow (ORCPT + 99 others); Wed, 6 May 2020 12:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730088AbgEFQov (ORCPT ); Wed, 6 May 2020 12:44:51 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA4EC061A0F for ; Wed, 6 May 2020 09:44:51 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id c3so1896220otp.8 for ; Wed, 06 May 2020 09:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l5ABB6HXdl4YnzQdkjQ1bvC7//77Zg5tnh+Hhr5dEHk=; b=TJn9RFT5f6Cll+89ffNEGHzFDJ+FYy+GygHp+stf8s9XrsfXAiOyOHiJlQPEy8LTn1 YakUrRb85zuBzb27uxC//sAvPF5bvh4rOo/UCP7S582/aDLliuJwcT9EueslgiWQ2Yql Vr497uinWRQ50ToNCvk8nWSBaxeyoMGONqDzXvoUSV2gti1yMvU6i4ZfW23y2Sw+WpvR 9p8k9o4YUe6vgQyhjFJYZJEKk2P9wGGJQ/fIiTa79ysQxwUjqmAIvtjJnuy61GfQmN/r fCsCbvZtwUJdI2xCoMN2VdanEwp0WaqJ1FFjZJdxhGCNgQyiGMXm2lKRp4sPW6dzC8Fv yjNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l5ABB6HXdl4YnzQdkjQ1bvC7//77Zg5tnh+Hhr5dEHk=; b=BBq03yDdJ75t4SbQ814LID9SY/H4N8x//3wovPtQY68DolI6Od77zPcNP42riF12JT 1DEr1WSyGmSihyVkoBWbIKr3n7PNfTSQL2HLe3WAsMfb08Nd6xD2ofoGaBLimT4PcD9l AQ3IGU1hNV9zipX3L9y1ZSPgicdLAEZPEafHwhGfVq4i+SgMxayk5exROs8w0eJqqpPr zUTzcGt0FkAAnmhF/AZe1iqTqiIroahZyLlXXTJ8tCZIhqnh5H2nEd8pZdw59nVjSqZ3 Xg8Uksi3fT8IExf+9zk46MUtx+ME1LM528En3XFtyEyxPxZ1WkOnNFNahKv+ovczVQPu YsbQ== X-Gm-Message-State: AGi0PuYQoSWS1ShkWnoLt55gHXUF+N/O0WsIm9mG2tdAR3jD0/lA1x/f 7wUfQz+IC77MA6T1kEgcOs15btBXbthGg8TyvwKvgapv X-Received: by 2002:a9d:57cb:: with SMTP id q11mr7301959oti.11.1588783490765; Wed, 06 May 2020 09:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20200501215352.23858-1-sonnysasaka@chromium.org> <4A9E7F0B-4AB8-4330-BB2B-1A0EAA4EFDE8@holtmann.org> In-Reply-To: From: Luiz Augusto von Dentz Date: Wed, 6 May 2020 09:44:38 -0700 Message-ID: Subject: Re: [PATCH] build: Add option to disable battery profile To: Bastien Nocera Cc: Marcel Holtmann , Sonny Sasaka , "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Sonny, On Wed, May 6, 2020 at 9:35 AM Luiz Augusto von Dentz wrote: > > Hi Marcel, Bastien, > > On Wed, May 6, 2020 at 7:14 AM Bastien Nocera wrote: > > > > On Wed, 2020-05-06 at 13:24 +0200, Marcel Holtmann wrote: > > > I have a little bit concern splitting this since battery service and > > > HoG are kinda connected. Wouldn=E2=80=99t it be better we have a clea= ner > > > interface. Maybe we should actually integrate cleanly with > > > /dev/upower or similar. > > > > Wat? > > I guess Marcel was refering to something like uhid though Im not sure > that exists, or does it? That said one alternative would make uhid > integrate the battery status, but I guess devices can also expose this > over hid directly so I wonder if we can translate the Battery Service > status to hid power strength that way we don't need any communication > over D-Bus. Btw, Im fine with the option to disable building the battery plugin since platforms may not have a use for it, so except if there are some strong reason against it I will apply the patch. --=20 Luiz Augusto von Dentz