Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200506005528.2897-1-sonnysasaka@chromium.org> <56F32068-E8EC-45DD-B233-DBDAFBFA0187@holtmann.org>
In-Reply-To: <56F32068-E8EC-45DD-B233-DBDAFBFA0187@holtmann.org>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Wed, 6 May 2020 10:05:16 -0700
Message-ID: <CAOxioN=XkDSDEE=PcZJf8JoTiDBPMoYpK1zAyRoReEUx9B-Mmg@mail.gmail.com>
Subject: Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

Chrome OS doesn't support HID-HCI switchable controllers so we would
like to remove this from being installed to reduce maintenance burden.
Disabling udev unfortunately also uninstalls sixaxis plugin, which we
still need. Do you have a suggestion how we can achieve this?

On Wed, May 6, 2020 at 4:06 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > ---
> > configure.ac | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..ba9937a16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -218,8 +218,11 @@ if (test "${enable_udev}" !=3D "no" && test -z "${=
path_udevdir}"); then
> > fi
> > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> >
> > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > +             [disable hid2hci tool]), [enable_hid2hci=3D${enableval}])
> > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" !=3D "no" &&
> > -                                             test "${enable_udev}" !=
=3D "no")
> > +                                     test "${enable_udev}" !=3D "no" &=
&
> > +                                     test "${enable_hid2hci}" !=3D "no=
")
>
> can you give me a bit of background why you need that. We did have that a=
nd I removed it in favor of putting everything behind udev. Mainly since we=
 really don=E2=80=99t need most of these things anymore. Can=E2=80=99t you =
just disable udev support and get the same result?
>
> Regards
>
> Marcel
>