Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH BlueZ] avrcp: Handle not implemented response to
 AVRCP_LIST_PLAYER_ATTRIBUTES
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org
References: <20200507210336.2703338-1-luiz.dentz@gmail.com>
From:   Andrey Semashev <andrey.semashev@gmail.com>
Message-ID: <f8aa3d48-c335-7ffa-c2f8-411bba6c21a0@gmail.com>
Date:   Fri, 8 May 2020 02:51:33 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200507210336.2703338-1-luiz.dentz@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

I think this patch is correct, but unfortunately, it doesn't solve the 
problem with the Sennheiser MTW2 reboot.

On 2020-05-08 00:03, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If remote device respond with ctype set to not implement don't continue
> parsing the packet.
> ---
>   profiles/audio/avrcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 6b3f685d2..773ccdb60 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -2223,7 +2223,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
>   	uint8_t len, count = 0;
>   	int i;
>   
> -	if (code == AVC_CTYPE_REJECTED)
> +	if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
>   		return FALSE;
>   
>   	len = pdu->params[0];
>