Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp11991ybk; Fri, 8 May 2020 17:00:59 -0700 (PDT) X-Google-Smtp-Source: APiQypIYDZRyfpmusK6UvZzmxMs41+PhPaFaMo2mSpEPMkg2p7qX/AVIGueOx5jHCLRm5MyvMIJx X-Received: by 2002:a17:906:8699:: with SMTP id g25mr4190422ejx.365.1588982459518; Fri, 08 May 2020 17:00:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588982459; cv=none; d=google.com; s=arc-20160816; b=tCFhP7g2TRQW3AWkTFMvsWgkDGlfCC0DGHyHYUupLUZsjrGiiQctFNWpuG3pWwHCgS bbScXPKahNAOfIr9mvZPwhAchotW9yHeFPPFCSltwBNWcCDYD412sCCpfp3x92ZRB33K O/f9vRBpJYzsDEjgrRqcG4regB3HELMlnG2K72jKX6wBxVrbSE0xVSOSUowgPU7bQPZB 60s17ALUpHJwX0GqsVJhgAdFdsBtJ0j+0jklge8kiQJ9RO8ZgLFaGA61WChUIs1N8I4c KGQjaYkdkIt92tilXgD8G9J8f6opxzkg0Kv1Oeg5cj2R9TOBsfb0NjR8o3xH0MFkLauX cMNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=H0YbyqHYG1SO6Exo/9yO+8RfV3MnyMx21RG1hFrJ4m0=; b=n9n4CAzM/H6US43cDVmeyjq7S5xgKl374vEFPktBAqCMaarqGFQF6rYxGsdnPv3iQ0 dMDOjlpdxLjDDre0Vy3VCcjGw8V6BA+/xgGsYjQQ1CeyXqT2Y2J48Q2t/CBKNzZmcxDK SiK0rvc3PTOJCCiEsbgoST1zGyljjVICKeIeUii1z1CUf9ZDJ2wifZ652VJXbJE5tj87 JyEkH2wsg6yG25aW0R5n2UPTm5jBEkFsm6EZr4mGEo0DGBOGS88Bv5XqI+e3nKA+UmK2 5iTrCC4GazIPyx7EF/lB5cvMFc98Ara2HP9anU7R78yIQjaLaFJF4CfNYY/pnSlfDrUU bs9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga21si1841833ejb.350.2020.05.08.17.00.36; Fri, 08 May 2020 17:00:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbgEIAA3 (ORCPT + 99 others); Fri, 8 May 2020 20:00:29 -0400 Received: from mga04.intel.com ([192.55.52.120]:65495 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728355AbgEIAA3 (ORCPT ); Fri, 8 May 2020 20:00:29 -0400 IronPort-SDR: HKNgkBykTiYCpD300QYiRJquypcTJUx6tR10jEbTMx8Ytfd1/doOdQLEphGVrC5Ik3cpzLq+oj CoDoUATfkN7w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 17:00:28 -0700 IronPort-SDR: nhvmxNV6WfY4j/zlroV9OY66zEWxkbldyePVncR8VYBFea9kYHChZVc/yEsSqI6ghPxBVCvreD 3cKGV6UKK5ww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,369,1583222400"; d="scan'208";a="408275107" Received: from ingas-nuc1.sea.intel.com ([10.254.110.242]) by orsmga004.jf.intel.com with ESMTP; 08 May 2020 17:00:28 -0700 From: Inga Stotland To: linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com, Inga Stotland Subject: [PATCH BlueZ 4/4] mesh: Remove redundant call to save node configuration Date: Fri, 8 May 2020 17:00:24 -0700 Message-Id: <20200509000024.5704-5-inga.stotland@intel.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200509000024.5704-1-inga.stotland@intel.com> References: <20200509000024.5704-1-inga.stotland@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This removes a redundant call to save node configuration in add_local_node(): there is a number of unconditional calls to mesh_config_write_() within this function which would result in the node configuration being saved implicitly. --- mesh/node.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mesh/node.c b/mesh/node.c index a96c0cae1..8914b639d 100644 --- a/mesh/node.c +++ b/mesh/node.c @@ -1366,8 +1366,6 @@ static bool add_local_node(struct mesh_node *node, uint16_t unicast, bool kr, update_net_settings(node); - mesh_config_save(node->cfg, true, NULL, NULL); - /* Initialize configuration server model */ cfgmod_server_init(node, PRIMARY_ELE_IDX); -- 2.21.3