Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200506005528.2897-1-sonnysasaka@chromium.org> <77B1AB20-C903-427C-A3BD-E10C79815EF9@holtmann.org>
In-Reply-To: <77B1AB20-C903-427C-A3BD-E10C79815EF9@holtmann.org>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Wed, 13 May 2020 14:41:06 -0700
Message-ID: <CAOxioNkki7ZXHgz5VoTcfYzukiupHgs4Z1KktMFm4Cn8BX3+Hg@mail.gmail.com>
Subject: Re: [PATCH] build: Add an option to explicitly disable installing hid2hci
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Thanks for the suggestion, Marcel. I have sent the v2 patch, please
take another look. Thanks.

On Wed, May 13, 2020 at 1:02 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > ---
> > configure.ac | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..ba9937a16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -218,8 +218,11 @@ if (test "${enable_udev}" != "no" && test -z "${path_udevdir}"); then
> > fi
> > AC_SUBST(UDEV_DIR, [${path_udevdir}])
> >
> > +AC_ARG_ENABLE(hid2hci, AC_HELP_STRING([--disable-hid2hci],
> > +             [disable hid2hci tool]), [enable_hid2hci=${enableval}])
> > AM_CONDITIONAL(HID2HCI, test "${enable_tools}" != "no" &&
> > -                                             test "${enable_udev}" != "no")
> > +                                     test "${enable_udev}" != "no" &&
> > +                                     test "${enable_hid2hci}" != "no")
>
> I looked at this again. Lets turn this around and make this an --enable-hid2hci similar to --enable-sixaxis.
>
> And you need to change the ${enable_tools} into ${enable_hid2hci} actually and not just add another dependency. Everything else seems to be already in the Makefile.tools for this.
>
> Regards
>
> Marcel
>