Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200528172525.216354-1-luiz.dentz@gmail.com> <20200528172525.216354-2-luiz.dentz@gmail.com>
 <0eb5cec7-a79a-a513-8303-a23b1bd7a0ce@gmail.com>
In-Reply-To: <0eb5cec7-a79a-a513-8303-a23b1bd7a0ce@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 28 May 2020 15:31:02 -0700
Message-ID: <CABBYNZLieGyLBWREu1E5D3W+bh-S48S0S5OY2KfQfs270+oniA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] avrcp: Don't attempt to load settings if on volume
 changed is supported
To:     Andrey Semashev <andrey.semashev@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Andrey,

On Thu, May 28, 2020 at 11:56 AM Andrey Semashev
<andrey.semashev@gmail.com> wrote:
>
> On 2020-05-28 20:25, Luiz Augusto von Dentz wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > If only volume changed is supported that means the player cannot really
> > indicate track/metadata changes so don't attempt to read them.
> > ---
> >   profiles/audio/avrcp.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> > index 75811bf98..d46ac0ab7 100644
> > --- a/profiles/audio/avrcp.c
> > +++ b/profiles/audio/avrcp.c
> > @@ -3814,6 +3814,10 @@ static gboolean avrcp_get_capabilities_resp(struct avctp *conn, uint8_t code,
> >       if (!session->controller || !session->controller->player)
> >               return FALSE;
> >
> > +     /* Skip if player status/metadata if only volume changes is supported */
> > +     if (events == AVRCP_EVENT_VOLUME_CHANGED)
> > +             return FALSE;
> > +
> >       if ((session->controller->features & AVRCP_FEATURE_PLAYER_SETTINGS) &&
> >                       !(events & (1 << AVRCP_EVENT_SETTINGS_CHANGED)))
> >               avrcp_list_player_attributes(session);
> >
>
> The result is still the same with this patch - MTW2 reboots after
> GetPlayStatus.

Looks like the test was wrong, Ive send a v3 fixing that.

-- 
Luiz Augusto von Dentz