Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Subject: Re: [PATCH v2 1/2] Bluetooth: Add support to Intel read supported
 feature
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200603101523.12547-1-kiran.k@intel.com>
Date:   Wed, 3 Jun 2020 19:42:20 +0200
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        ravishankar.srivatsa@intel.com,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Ps@vger.kernel.org, AyappadasX <AyappadasX.Ps@intel.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <E929E0E0-E28A-4874-B168-A5E03C40F1F8@holtmann.org>
References: <20200603101523.12547-1-kiran.k@intel.com>
To:     Kiran K <kiran.k@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Kiran,

> The command shall read the Intel controller supported
> feature. Based on the supported features addtional debug
> configuration shall be enabled.
> 
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Signed-off-by: Ps, AyappadasX <AyappadasX.Ps@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
> drivers/bluetooth/btintel.c | 34 ++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btintel.h | 14 ++++++++++++++
> drivers/bluetooth/btusb.c   |  8 +++++++-
> 3 files changed, 55 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 6a0e2c5a8beb..09e697b92426 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -754,6 +754,40 @@ void btintel_reset_to_bootloader(struct hci_dev *hdev)
> }
> EXPORT_SYMBOL_GPL(btintel_reset_to_bootloader);
> 
> +int btintel_read_supported_features(struct hci_dev *hdev,
> +	struct intel_supported_features *supported_features)
> +{
> +	struct sk_buff *skb;
> +	u8 page_no = 1;
> +
> +	/* Intel controller supports two pages, each page is of 128-bit
> +	 * feature bit mask. And each bit defines specific feature support
> +	 */
> +	skb = __hci_cmd_sync(hdev, 0xfca6, sizeof(page_no), &page_no,
> +		HCI_INIT_TIMEOUT);

Please get the coding style right first. We have plenty of examples in the same file on how to do this.

Regards

Marcel