Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5ed9d9c7.1c69fb81.a6149.34e7@mx.google.com>
Date:   Thu, 04 Jun 2020 22:36:07 -0700 (PDT)
Content-Type: multipart/mixed; boundary="===============7806691646011392002=="
MIME-Version: 1.0
From:   bluez.test.bot@gmail.com
To:     linux-bluetooth@vger.kernel.org, tedd.an@linux.intel.com
Subject: RE: [2/2] tools/btpclient: Use mgmt api for limited discovery
Reply-To: linux-bluetooth@vger.kernel.org
In-Reply-To: <20200605051509.10766-2-tedd.an@linux.intel.com>
References: <20200605051509.10766-2-tedd.an@linux.intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

--===============7806691646011392002==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#32: FILE: tools/btpclient.c:85:
+static struct mgmt *mgmt = NULL;

ERROR:SPACING: space required before the open parenthesis '('
#225: FILE: tools/btpclient.c:3294:
+	else if(strlen(arg) > 3 && !strncasecmp(arg, "hci", 3))

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - void btp_mgmt_release() should probably be void btp_mgmt_release(void)
#248: FILE: tools/btpclient.c:3317:
+static void btp_mgmt_release()

WARNING:LONG_LINE: line over 80 characters
#266: FILE: tools/btpclient.c:3334:
+	while ((opt = getopt_long(argc, argv, "+hs:vqi:", options, NULL)) != -1) {

- total: 3 errors, 1 warnings, 271 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


---
Regards,
Linux Bluetooth

--===============7806691646011392002==--